Skip to content

Commit 91fa3d0

Browse files
committed
Remove code signing from release action
The Azure Trusted Signing service is still not yet supported by nuget tooling
1 parent b03e615 commit 91fa3d0

File tree

1 file changed

+1
-36
lines changed

1 file changed

+1
-36
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@ env:
1818
RepositoryCommit: '${{ github.sha }}'
1919

2020
jobs:
21-
build:
22-
21+
release:
2322
runs-on: ubuntu-22.04
2423

2524
steps:
@@ -51,41 +50,7 @@ jobs:
5150
${{ github.workspace }}/dist
5251
${{ github.workspace }}/src/Kavod.Vba.Compression/README.md
5352
54-
sign:
55-
needs: build
56-
runs-on: windows-2022
57-
58-
steps:
59-
- name: download artifact
60-
uses: actions/download-artifact@v4
61-
with:
62-
name: VbaCompression_packages
63-
path: ${{ github.workspace }}
64-
65-
- name: setup dotnet
66-
uses: actions/setup-dotnet@v4
67-
with:
68-
dotnet-version: 6
69-
70-
- name: setup NuGetKeyVaultSignTool
71-
run: dotnet tool install --verbosity minimal --global NuGetKeyVaultSignTool --version 3.2.3
72-
73-
- name: sign
74-
id: sign_package
75-
working-directory: '${{ github.workspace}}/dist'
76-
run: |
77-
NuGetKeyVaultSignTool.exe sign *.nupkg `
78-
--file-digest sha256 `
79-
--timestamp-rfc3161 http://timestamp.digicert.com `
80-
--timestamp-digest sha256 `
81-
--azure-key-vault-url "${{ secrets.KEYVAULT_URL }}" `
82-
--azure-key-vault-tenant-id "${{ secrets.KEYVAULT_TENANT_ID }}" `
83-
--azure-key-vault-client-id "${{ secrets.KEYVAULT_CLIENT_ID }}" `
84-
--azure-key-vault-client-secret "${{ secrets.AZURESIGNTOOL_CLIENT_SECRET }}" `
85-
--azure-key-vault-certificate "goITSolutions-until-2024-01"
86-
8753
- name: publish
88-
if: ${{ steps.sign_package.outcome == 'success' }}
8954
working-directory: '${{ github.workspace}}/dist'
9055
run: |
9156
dotnet nuget push "*.nupkg" --api-key $env:NUGET_PUSH_KEY --source https://api.nuget.org/v3/index.json

0 commit comments

Comments
 (0)