Skip to content

Commit 6a09a6f

Browse files
committed
Logging of performance per config file
1 parent ccba27d commit 6a09a6f

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

accesscontroltool-bundle/src/main/java/biz/netcentric/cq/tools/actool/configreader/YamlConfigurationMerger.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,7 @@ public AcConfiguration getMergedConfigurations(
9191
final ConfigReader configReader, Session session) throws RepositoryException,
9292
AcConfigBeanValidationException {
9393

94-
StopWatch sw = new StopWatch();
95-
sw.start();
94+
long wholeConfigStart = System.currentTimeMillis();
9695

9796
final GlobalConfiguration globalConfiguration = new GlobalConfiguration();
9897
final AuthorizablesConfig mergedAuthorizablesBeansfromConfig = new AuthorizablesConfig();
@@ -116,6 +115,8 @@ public AcConfiguration getMergedConfigurations(
116115

117116
for (final Map.Entry<String, String> entry : configFileContentByFilename.entrySet()) {
118117

118+
long configFileStart = System.currentTimeMillis();
119+
119120
String sourceFile = entry.getKey();
120121
installLog.addMessage(LOG, "Using configuration file " + sourceFile);
121122

@@ -200,6 +201,9 @@ public AcConfiguration getMergedConfigurations(
200201
// --- obsolete authorizables config section
201202
obsoleteAuthorizables.addAll(configReader.getObsoluteAuthorizables(yamlRootList));
202203
obsoleteAuthorizablesValidator.validate(obsoleteAuthorizables, authorizableIdsFromAllConfigs, sourceFile);
204+
205+
installLog.addVerboseMessage(LOG,
206+
"Loaded configuration file " + sourceFile + " in " + msHumanReadable(System.currentTimeMillis() - configFileStart));
203207
}
204208

205209
ensureIsMemberOfIsUsedWherePossible(mergedAuthorizablesBeansfromConfig, installLog);
@@ -217,13 +221,13 @@ public AcConfiguration getMergedConfigurations(
217221
testUserConfigsCreator.createTestUserConfigs(acConfiguration, installLog);
218222

219223
if(!Boolean.TRUE.equals(globalConfiguration.getAllowCreateOfUnmanagedRelationships())) {
220-
UnmangedExternalMemberRelationshipChecker.validate(acConfiguration);
224+
UnmangedExternalMemberRelationshipChecker.validate(acConfiguration);
221225
}
222226

223227
installLog.setMergedAndProcessedConfig(
224228
"# Merged configuration of " + configFileContentByFilename.size() + " files \n" + yamlParser.dump(acConfiguration));
225229

226-
installLog.addMessage(LOG, "Loaded configuration in " + msHumanReadable(sw.getTime()));
230+
installLog.addMessage(LOG, "Loaded configuration in " + msHumanReadable(System.currentTimeMillis() - wholeConfigStart));
227231

228232
return acConfiguration;
229233
}

0 commit comments

Comments
 (0)