Skip to content

Commit fbc2613

Browse files
committed
always build javadoc
fix javadocs attach source and javadoc during release
1 parent ab93d20 commit fbc2613

File tree

4 files changed

+22
-7
lines changed

4 files changed

+22
-7
lines changed

aem-classification-validator/src/main/java/biz/netcentric/filevault/validator/aem/classification/ContentClassification.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ public boolean isAllowed(ContentUsage contentUsage) {
7171

7272
/**
7373
*
74-
* @param contentUsages
75-
* @return only {@true} in case all {@link contentUsages} are allowed
74+
* @param contentUsages the usages to check for
75+
* @return only {@code true} in case all {@code contentUsages} are allowed
7676
*/
7777
public boolean isAllowed(EnumSet<ContentUsage> contentUsages) {
7878
return Collections.disjoint(disallowedUsages, contentUsages);

aem-classification-validator/src/main/java/biz/netcentric/filevault/validator/aem/classification/ContentClassificationMapper.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ public interface ContentClassificationMapper {
2929

3030
/**
3131
* Returns the classification for the given resource type.
32+
* In case the given {@code resourcePath} matches any of the {@code whiteLilstedResourcePaths} it returns PUBLIC.
3233
* @param resourcePath the absolute resource path
34+
* @param whitelistedResourcePaths the whitelisted resource paths as regular expression patterns.
3335
* @return the classification and the optional remark belonging to the given resource type
3436
*/
3537
@NotNull Entry<ContentClassification, String> getContentClassificationAndRemarkForResourcePath(@NotNull String resourcePath, @Nullable Collection<Pattern> whitelistedResourcePaths);
@@ -38,10 +40,10 @@ public interface ContentClassificationMapper {
3840
* Writes the map to a given output stream.
3941
* Leaves the output stream open.
4042
*
41-
* @param inputStream
42-
* @throws IOException
43+
* @param outputStream the stream to write to
44+
* @throws IOException in case of any exception during writing
4345
*/
44-
void write(@NotNull OutputStream inputStream) throws IOException;
46+
void write(@NotNull OutputStream outputStream) throws IOException;
4547

4648
/**
4749
* Adds a new entry to the classification map.

aem-classification-validator/src/main/java/biz/netcentric/filevault/validator/aem/classification/ContentClassificationMapperImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
* map and has the format
4949
*
5050
* <pre>
51-
* &#60;path&#62;,&#60;classification&#62{,&#60;remark&#62;}
51+
* &#60;path&#62;,&#60;classification&#62;{,&#60;remark&#62;}
5252
* </pre>
5353
*
5454
* where {@code classification} is one of {@link ContentClassification}. The CSV format is

pom.xml

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,20 @@
248248
</execution>
249249
</executions>
250250
</plugin>
251+
<!-- always generate javadoc -->
252+
<plugin>
253+
<groupId>org.apache.maven.plugins</groupId>
254+
<artifactId>maven-javadoc-plugin</artifactId>
255+
<executions>
256+
<execution>
257+
<id>generate-javadoc</id>
258+
<goals>
259+
<goal>javadoc</goal>
260+
</goals>
261+
<phase>verify</phase>
262+
</execution>
263+
</executions>
264+
</plugin>
251265
<plugin>
252266
<artifactId>maven-release-plugin</artifactId>
253267
<configuration>
@@ -294,7 +308,6 @@
294308
</plugins>
295309
</build>
296310
<profiles>
297-
298311
<profile>
299312
<id>release</id>
300313
<activation>

0 commit comments

Comments
 (0)