fix: path mapping for a real case with mistyped slashes

Author: CountRedClaw

src/openapi/openapi3.mapping.ts

@@ -1,5 +1,12 @@
 import { MapKeysResult, MappingResolver, NodeContext } from '../types'
-import { difference, getStringValue, intersection, objectKeys, onlyExistedArrayIndexes } from '../utils'
+import {
+  difference,
+  getStringValue,
+  intersection,
+  objectKeys,
+  onlyExistedArrayIndexes,
+  removeSlashes,
+} from '../utils'
 import { mapPathParams } from './openapi3.utils'
 import { OpenAPIV3 } from 'openapi-types'
 
@@ -206,11 +213,7 @@ export const extractOperationBasePath = (servers?: OpenAPIV3.ServerObject[]): st
 
 export function createPathUnifier(nodeContext: NodeContext): (path: string) => string {
   const serverPrefix = extractOperationBasePath((nodeContext.root as OpenAPIV3.Document).servers) // /api/v2
-  return (path) => (
-    serverPrefix
-      ? `${serverPrefix}${hidePathParamNames(path)}`
-      : hidePathParamNames(path)
-  )
+  return (path) => removeSlashes(`${serverPrefix}${hidePathParamNames(path)}`)
 }
 
 export function hidePathParamNames(path: string): string {

src/utils.ts

@@ -231,3 +231,7 @@ export function difference(array1: string[], array2: string[]): string[] {
   const set2 = new Set(array2)
   return [...new Set(array1.filter(x => !set2.has(x)))]
 }
+
+export function removeSlashes(input: string): string {
+  return input.replace(/\//g, '')
+}

test/openapi.pathAndMethodMapping.test.ts

@@ -57,4 +57,33 @@ describe('Path and method mapping', () => {
       }),
     ]))
   })
+
+  it('Remove mistyped slashes', () => {
+    const before = openapiBuilder
+      .addPath({
+        path: '//path1/',
+        responses: { '200': { description: 'OK' } },
+      })
+      .getSpec()
+
+    openapiBuilder.reset()
+
+    const after = openapiBuilder
+      .addPath({
+        path: '/path1',
+        responses: { '200': { description: 'OK' } },
+      })
+      .getSpec()
+
+    const { diffs } = apiDiff(before, after)
+
+    expect(diffs).toEqual(diffsMatcher([
+      expect.objectContaining({
+        beforeDeclarationPaths: [['paths', '//path1/']],
+        afterDeclarationPaths: [['paths', '/path1']],
+        action: DiffAction.rename,
+        type: breaking, // todo should be annotation
+      })
+    ]))
+  })
 })