refactor: rename semi-breaking changes to risky in FE code #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iurii-golovinskii
changed the title
JayLim2
reviewed
Apr 7, 2025
| annotation: 'annotation', | ||
| unclassified: 'unclassified', | ||
| deprecated: 'deprecated', | ||
| } as const |
There was a problem hiding this comment.
so we finally decided to get rid of "semi-breaking" term or is this another layer?
There was a problem hiding this comment.
In scope of this issue- we get rename semi-breaking to risky in all the code FE team is responsible to.
So, the only place when semi-breaking term could be used is in a mapping DTOs received from BE (where semi-breaking is not renamed) and FE entities.
CountRedClaw
approved these changes
Apr 11, 2025
…ame-label-semi-breaking-changes-two
b41ex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.