review

Author: Iurii Golovinskii

src/apitypes/rest/rest.changes.ts

@@ -59,9 +59,8 @@ export const compareRestOperationsData = async (current: VersionRestOperation |
       normalizedResult: true,
       beforeSource: previous?.data,
       afterSource: current?.data,
-    }
+    },
   )
-  console.log('Тутэн')
   const olnyBreaking = diffResult.diffs.filter((diff) => diff.type === breaking)
   if (olnyBreaking.length > 0 && previous?.operationId) {
     await reclassifyBreakingChanges(previous.operationId, diffResult.merged, olnyBreaking, ctx)
@@ -73,9 +72,8 @@ async function reclassifyBreakingChanges(
   operationId: string,
   mergedJso: unknown,
   diffs: Diff[],
-  ctx: CompareOperationsPairContext
+  ctx: CompareOperationsPairContext,
 ): Promise<void> {
-  console.log('Тутэн')
   if (!ctx.previousVersion || !ctx.previousPackageId) {
     return
   }
@@ -84,6 +82,7 @@ async function reclassifyBreakingChanges(
     return
   }
   previosVersionDeprecations.operations[0]
+
   const previousOperation = previosVersionDeprecations.operations[0]
 
   if (!previousOperation?.deprecatedItems) { return }
@@ -95,7 +94,6 @@ async function reclassifyBreakingChanges(
 
     const deprecatedInVersionsCount = previousOperation?.deprecatedInPreviousVersions?.length ?? 0
     if (isOperationRemove(diff) && deprecatedInVersionsCount > 1) {
-      console.log('Тутэн')
       diff.type = risky
       continue
     }
@@ -142,15 +140,11 @@ async function reclassifyBreakingChanges(
       diff.type = risky
     }
   }
-
-
   // mark removed required status of the property as risky
   if (diffs.length) {
     const requiredProperties = findRequiredRemovedProperties(mergedJso, diffs)
-    //console.log('requiredProperties----->', requiredProperties)
 
     requiredProperties?.forEach(prop => {
-   //   console.log('requiredProperties----->', prop.propDiff)
       if (prop.propDiff.type === RISKY_CHANGE_TYPE && prop.requiredDiff?.type === BREAKING_CHANGE_TYPE) {
         prop.requiredDiff.type = risky
       }

src/utils/transformToDto.ts

@@ -194,23 +194,18 @@ export function replacePropertyInChangesSummary<
     origin: SEMI_BREAKING_CHANGE_TYPE,
     override: risky,
   }): ChangeSummary<J> {
-  if (Object.prototype.hasOwnProperty.call(obj, origin)) {
-    const copyObj= {...obj}
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
-    copyObj[override] = copyObj[origin]
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
-    delete copyObj[origin]
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
-    return copyObj
-  } else {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
-    return obj
-  }
+  {
+    if (origin in obj) {
+      const copyObj = { ...obj } as Record<PropertyKey, unknown>
+
+      copyObj[override] = copyObj[origin]
+      delete copyObj[origin]
 
+      return copyObj as ChangeSummary<J>
+    }
+
+    return obj as unknown as ChangeSummary<J>
+  }
 }
 
 export type DiffTypeCompare = DiffType | DiffTypeDto

test/deprecated.test.ts

@@ -89,8 +89,6 @@ describe('Deprecated Items test', () => {
     }, {}, portal)
 
     const result = await editor.run()
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
     expect(result.comparisons[0].operationTypes[0].changesSummary?.[RISKY_CHANGE_TYPE]).toBe(1)
     expect(result.comparisons[0].operationTypes[0].changesSummary?.[BREAKING_CHANGE_TYPE]).toBe(0)
   })

test/tests-v2/changelog.test.ts

@@ -882,7 +882,7 @@ describe.skip('Change Log', () => {
     // expect(ar.notifications.length).toEqual(0)
   })
 
-  test.only('B-OA30-Y-CL-30.2 Adding oneOf', async () => {
+  test('B-OA30-Y-CL-30.2 Adding oneOf', async () => {
     const version = 'v31.2'
     const er = await registry.getVersion(packageId, version)