fix: extra leading dash in the the operation id when comparing prefix groups

Author: b41ex

src/components/compare/compare.utils.ts

@@ -146,7 +146,7 @@ export function normalizeOperationIds(operations: ResolvedOperation[], apiBuilde
   operations.forEach(operation => {
     const normalizedOperationId = apiBuilder.createNormalizedOperationId?.(operation) ?? operation.operationId
     // '-' is a slugified slash in the middle of a normalizedOperationId that should also be removed for a proper matching during comparison
-    normalizedOperationIdToOperation[takeSubstringIf(!!groupSlug, normalizedOperationId, groupSlug.length + '-'.length)] = operation
+    normalizedOperationIdToOperation[removeGroupPrefixFromOperationId(normalizedOperationId, groupSlug)] = operation
   })
   return [Object.keys(normalizedOperationIdToOperation), normalizedOperationIdToOperation]
 }
@@ -268,13 +268,13 @@ export function createOperationChange(
   const impactedSummary = calculateImpactedSummary([changeSummary])
 
   const currentOperationFields = current && {
-    operationId: takeSubstringIf(!!currentGroup, current.operationId, removeFirstSlash(currentGroup ?? '').length),
+    operationId: removeGroupPrefixFromOperationId(current.operationId, currentGroup ?? ''),
     apiKind: current.apiKind,
     metadata: getOperationMetadata(current),
   }
 
   const previousOperationFields = previous && {
-    previousOperationId: takeSubstringIf(!!previousGroup, previous.operationId, removeFirstSlash(previousGroup ?? '').length),
+    previousOperationId: removeGroupPrefixFromOperationId(previous.operationId, previousGroup ?? ''),
     previousApiKind: previous.apiKind,
     previousMetadata: getOperationMetadata(previous),
   }
@@ -288,3 +288,7 @@ export function createOperationChange(
     ...previousOperationFields,
   }
 }
+
+export const removeGroupPrefixFromOperationId = (operationId: string, groupPrefix: string): string => {
+  return takeSubstringIf(!!groupPrefix, operationId, removeFirstSlash(groupPrefix).length + '-'.length)
+}

test/prefix-groups.test.ts

@@ -20,6 +20,7 @@ import {
   Editor,
   LocalRegistry,
   numberOfImpactedOperationsMatcher,
+  operationChangesMatcher,
 } from './helpers'
 import { ANNOTATION_CHANGE_TYPE, BREAKING_CHANGE_TYPE, BUILD_TYPE, NON_BREAKING_CHANGE_TYPE } from '../src'
 
@@ -101,6 +102,17 @@ describe('Prefix Groups test', () => {
       config: { files: [{ fileId: 'spec1.yaml' }, { fileId: 'spec2.yaml' }] },
     })
 
+    expect(result).toEqual(operationChangesMatcher([
+      expect.objectContaining({
+        previousOperationId: 'removed-get',
+      }),
+      expect.objectContaining({
+        operationId: 'added-get',
+      }),
+      expect.objectContaining({
+        operationId: 'changed1-get',
+      }),
+    ]))
     expect(result).toEqual(changesSummaryMatcher({
       [BREAKING_CHANGE_TYPE]: 1,
       [NON_BREAKING_CHANGE_TYPE]: 1,