feat: Review

Author: makeev-pavel

test/builder.test.ts

@@ -145,4 +145,33 @@ describe('Editor scenarios', () => {
       })
     })
   })
+
+  describe('PathItems build', () => {
+    const COMPONENTS_ITEM_1_PATH = ['components', 'pathItems', 'componentsPathItem1']
+    test('should have separate operations with pathitems', async () => {
+      const pkg = LocalRegistry.openPackage('builder/define-pathitems-via-reference-object-chain')
+      const editor = await Editor.openProject(pkg.packageId, pkg)
+
+      await pkg.publish(pkg.packageId, { packageId: pkg.packageId })
+      const result = await editor.run({
+        version: 'v1',
+        status: VERSION_STATUS.RELEASE,
+        buildType: BUILD_TYPE.BUILD,
+      })
+
+      const resultOperations = Array.from(result.operations.values())
+      expect(resultOperations.length).toEqual(2)
+
+      const [postOperation, getOperation] = resultOperations
+      // check that we have only path operation in componentsPathItem1 for path1-post
+      expect(postOperation.operationId).toEqual('path1-post')
+      expect(postOperation.data).toHaveProperty([...COMPONENTS_ITEM_1_PATH, 'post'])
+      expect(postOperation.data).not.toHaveProperty([...COMPONENTS_ITEM_1_PATH, 'get'])
+
+      // check that we have only get operation in componentsPathItem1 for path1-get
+      expect(getOperation.operationId).toEqual('path1-get')
+      expect(getOperation.data).not.toHaveProperty([...COMPONENTS_ITEM_1_PATH, 'post'])
+      expect(getOperation.data).toHaveProperty([...COMPONENTS_ITEM_1_PATH, 'get'])
+    })
+  })
 })

test/merge/openapi/openapi.test.ts

@@ -258,16 +258,16 @@ describe('Merge openapi schemas', () => {
   })
 
   test('Should throw on different methods content', async () => {
-    // 1: [[../should-throw-on-different-methods/case1/1.yaml]]
-    // 2: [[../should-throw-on-different-methods/case1/2.yaml]]
-    const testId = 'should-throw-on-different-methods/case1'
+    // 1: [[../should-throw-on-different-methods/should-throw-on-different-methods-in-path/1.yaml]]
+    // 2: [[../should-throw-on-different-methods/should-throw-on-different-methods-in-path/2.yaml]]
+    const testId = 'should-throw-on-different-methods/should-throw-on-different-methods-in-path'
     await expect(getTestData(testId)).rejects.toThrowError(/paths.\/path1/)
   })
 
   test('Should throw on different pathItems methods content', async () => {
-    // 1: [[../should-throw-on-different-methods/case2/1.yaml]]
-    // 2: [[../should-throw-on-different-methods/case2/2.yaml]]
-    const testId = 'should-throw-on-different-methods/case2'
+    // 1: [[../should-throw-on-different-methods/should-throw-on-different-methods-in-pathItem-component/1.yaml]]
+    // 2: [[../should-throw-on-different-methods/should-throw-on-different-methods-in-pathItem-component/2.yaml]]
+    const testId = 'should-throw-on-different-methods/should-throw-on-different-methods-in-pathItem-component'
     await expect(getTestData(testId)).rejects.toThrowError(/components.pathItems.path1/)
   })
 

test/merge/openapi/should-throw-on-different-methods/case1/1.yaml renamed to test/merge/openapi/should-throw-on-different-methods/should-throw-on-different-methods-in-path/1.yaml

@@ -0,0 +1,34 @@
+openapi: 3.1.0
+info:
+  title: Pet Store API
+  version: 1.0.0
+paths:
+  /path1:
+    $ref: '#/components/pathItems/componentsPathItem'
+components:
+  schemas:
+    MySchema:
+      type: object
+      properties:
+        message:
+          type: string
+  pathItems:
+    componentsPathItem:
+      $ref: '#/components/pathItems/componentsPathItem1'
+    componentsPathItem1:
+      post:
+        responses:
+          '200':
+            description: Pet successfully added
+            content:
+              application/json:
+                schema:
+                  $ref: '#/components/schemas/MySchema'
+      get:
+        responses:
+          '200':
+            description: Pet successfully added
+            content:
+              application/json:
+                schema:
+                  $ref: '#/components/schemas/MySchema'

test/merge/openapi/should-throw-on-different-methods/case1/2.yaml renamed to test/merge/openapi/should-throw-on-different-methods/should-throw-on-different-methods-in-path/2.yaml

@@ -0,0 +1,13 @@
+{
+  "packageId": "55",
+  "apiType": "rest",
+  "version": "v1",
+  "files": [
+    {
+      "fileId": "1.yaml",
+      "publish": true,
+      "labels": [],
+      "commitId": "6c778b1f44200bd19944a6a8eac10a4e5a21a3cd"
+    }
+  ]
+}