fix: loss of documents due to fileId/filename coincidence

Author: CountRedClaw

src/strategies/document-group.strategy.ts

@@ -39,6 +39,7 @@ import { VersionRestDocument } from '../apitypes/rest/rest.types'
 import { INLINE_REFS_FLAG, NORMALIZE_OPTIONS } from '../consts'
 import { normalize } from '@netcracker/qubership-apihub-api-unifier'
 import { calculateSpecRefs, extractCommonPathItemProperties } from '../apitypes/rest/rest.operation'
+import { groupBy } from 'graphql/jsutils/groupBy'
 
 async function getTransformedDocument(document: ResolvedDocument, format: FileFormat): Promise<VersionRestDocument> {
   const versionDocument = toVersionDocument(document, format)
@@ -94,15 +95,37 @@ export class DocumentGroupStrategy implements BuilderStrategy {
     }
 
     const transformedDocuments = await Promise.all(transformTasks)
+    const transformedDocumentsWithoutCollisions = (['fileId', 'filename'] as const).reduce(resolveCollisions, transformedDocuments)
 
-    for (const transformedDocument of transformedDocuments) {
-      buildResult.documents.set(transformedDocument.fileId, transformedDocument)
+    for (const document of transformedDocumentsWithoutCollisions) {
+      buildResult.documents.set(document.fileId, document)
     }
 
     return buildResult
   }
 }
 
+// there is a chance that the renamed document will be the same as another document (this case has not been fixed yet)
+function resolveCollisions(docs: VersionRestDocument[], field: 'fileId' | 'filename'): VersionRestDocument[] {
+  const fileIdMap = groupBy(docs, (document) => document[field])
+  return ([...fileIdMap.values()] as VersionRestDocument[][]).reduce((acc, docs) => {
+    const [_, ...rest] = docs
+    rest.forEach((document, index) => {document[field] = addPostfix(` ${index + 1}`, document[field])})
+    return [...acc, ...docs]
+  }, [] as VersionRestDocument[])
+}
+
+function addPostfix(postfix: string, fileName: string): string {
+  const nameParts = fileName.split('.')
+  const extension = nameParts.length > 1 ? nameParts[nameParts?.length - 1] : ''
+  const nameWithPostfix = `${nameParts[0]}${postfix}`
+
+  if (extension) {
+    return `${nameWithPostfix}.${extension}`
+  }
+  return nameWithPostfix
+}
+
 function parseBase64String(value: string): object {
   return JSON.parse(fromBase64(value))
 }