review 4

Author: Iurii Golovinskii

src/types/package/comparisons.ts

@@ -18,6 +18,8 @@ import { ChangeSummary, DiffTypeDto, OperationId, OperationType, PackageId, Vers
 import { ActionType, DiffAction, DiffType } from '@netcracker/qubership-apihub-api-diff'
 import { JsonPath } from '@netcracker/qubership-apihub-json-crawl'
 
+export type ChangeMessage<T = DiffType> = ChangeAdd<T> | ChangeRemove<T> | ChangeReplace<T> | ChangeRename<T>
+
 export interface PackageComparisons {
   comparisons: PackageComparison[]
 }
@@ -82,5 +84,3 @@ export interface ChangeRename<T> extends ChangeBase<T> {
   currentKey: unknown
   previousKey: unknown
 }
-
-export type ChangeMessage<T = DiffType> = ChangeAdd<T> | ChangeRemove<T> | ChangeReplace<T> | ChangeRename<T>

test/deprecated.test.ts

@@ -103,8 +103,6 @@ describe('Deprecated Items test', () => {
     }, {}, portal)
 
     const result = await editor.run()
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
     expect(result.comparisons[0].operationTypes[0].changesSummary?.[RISKY_CHANGE_TYPE]).toBe(4)
   })
 })

test/performance.ts

@@ -44,4 +44,3 @@ await portal.publish('performance', {
         { fileId: '2024.1/openapi_large_x6.yaml' },
     ],
 })
-console.log('DONE')

test/risky-changes.test.ts

@@ -50,8 +50,6 @@ describe('Risky changes test', () => {
     }, {}, portal)
 
     const result = await editor.run()
-
-
     expect(result).toEqual(changesSummaryMatcher({
       [NON_BREAKING_CHANGE_TYPE]: 1,
       [RISKY_CHANGE_TYPE]: 1,
@@ -92,8 +90,6 @@ describe('Risky changes test', () => {
     }, {}, portal)
 
     const result = await editor.run()
-
-
     expect(result).toEqual(changesSummaryMatcher({
       [BREAKING_CHANGE_TYPE]: 1,
       [RISKY_CHANGE_TYPE]: 1,