review 5

Author: Iurii Golovinskii

src/components/package.ts

@@ -29,7 +29,8 @@ import {
   PackageNotifications,
   PackageOperation,
   PackageOperations,
-  VersionDocument, VersionsComparisonDto, BuildResult,
+  VersionDocument,
+  BuildResult,
 } from '../types'
 import { unknownApiBuilder } from '../apitypes'
 import { MESSAGE_SEVERITY, PACKAGE } from '../consts'
@@ -57,7 +58,7 @@ export const createVersionPackage = async (
   }
   const buildResultDto: BuildResultDto = {
     ...buildResult,
-    comparisons: buildResult.comparisons.map(comparison => toVersionsComparisonDto(comparison, logError)) as VersionsComparisonDto[],
+    comparisons: buildResult.comparisons.map(comparison => toVersionsComparisonDto(comparison, logError)),
   }
 
   await createInfoFile(zip, buildResultDto.config)

src/types/internal/compare.ts

@@ -81,7 +81,7 @@ export interface VersionsComparison<T extends DiffType | DiffTypeDto = DiffType>
   data?: OperationChanges[]
 }
 
-export interface VersionsComparisonDto<T extends DiffType | DiffTypeDto = DiffTypeDto> extends Omit<VersionsComparison<T>, 'data'> {
+export interface VersionsComparisonDto extends Omit<VersionsComparison<DiffTypeDto>, 'data'> {
   data?: OperationChangesDto[]
 }