refactor: add test for path parameter name path fragment collision

Author: b41ex

src/apitypes/graphql/graphql.operations.ts

@@ -18,7 +18,7 @@ import type { VersionGraphQLOperation } from './graphql.types'
 import { removeComponents, slugify } from '../../utils'
 import type { OperationsBuilder } from '../../types'
 import { GRAPHQL_TYPE, GRAPHQL_TYPE_KEYS } from './graphql.consts'
-import { INLINE_REFS_FLAG, MESSAGE_SEVERITY, NORMALIZE_OPTIONS, ORIGINS_SYMBOL } from '../../consts'
+import { INLINE_REFS_FLAG, NORMALIZE_OPTIONS, ORIGINS_SYMBOL } from '../../consts'
 import { GraphApiSchema } from '@netcracker/qubership-apihub-graphapi'
 import { buildGraphQLOperation } from './graphql.operation'
 import { asyncFunction } from '../../utils/async'

src/apitypes/rest/rest.operations.ts

@@ -24,7 +24,7 @@ import {
   removeComponents,
 } from '../../utils'
 import type * as TYPE from './rest.types'
-import { HASH_FLAG, INLINE_REFS_FLAG, MESSAGE_SEVERITY, NORMALIZE_OPTIONS, ORIGINS_SYMBOL } from '../../consts'
+import { HASH_FLAG, INLINE_REFS_FLAG, NORMALIZE_OPTIONS, ORIGINS_SYMBOL } from '../../consts'
 import { asyncFunction } from '../../utils/async'
 import { logLongBuild, syncDebugPerformance } from '../../utils/logs'
 import { normalize, RefErrorType } from '@netcracker/qubership-apihub-api-unifier'

test/bugs.test.ts

@@ -384,4 +384,17 @@ describe('Operation Bugs', () => {
       ],
     })).rejects.toThrow('Duplicated operation with operationId \'res-data-post\' found')
   })
+
+  //TODO: need to decide how to handle this case, this affects how operationIds are calculated
+  test.skip('Should build operations if there is a path parameter path collision', async () => {
+    const pkg = LocalRegistry.openPackage('path-parameter-path-collision')
+
+    const result = await pkg.publish(pkg.packageId, {
+      packageId: pkg.packageId,
+      version: 'v1',
+      files: [
+        { fileId: 'spec.json' },
+      ],
+    })
+  })
 })

test/projects/path-parameter-path-collision/spec.json

@@ -0,0 +1,68 @@
+{
+  "openapi": "3.0.1",
+  "info": {
+    "title": "REST",
+    "description": "",
+    "version": "1.0"
+  },
+  "paths": {
+    "/api/v1/provider/{entities}": {
+      "delete": {
+        "summary": "Delete entities",
+        "operationId": "deleteEntities",
+        "parameters": [
+          {
+            "name": "entities",
+            "in": "path",
+            "description": "Entities",
+            "required": true,
+            "schema": {
+              "type": "string"
+            }
+          }
+        ],
+        "responses": {
+          "200": {
+            "description": "Entities were deleted successfully",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "type": "object"
+                }
+              }
+            }
+          }
+        }
+      }
+    },
+    "/api/v1/provider/entities": {
+      "delete": {
+        "summary": "Delete entities by key",
+        "operationId": "deleteEntitiesByKey",
+        "parameters": [
+          {
+            "name": "Key",
+            "in": "query",
+            "description": "key",
+            "required": true,
+            "schema": {
+              "type": "string"
+            }
+          }
+        ],
+        "responses": {
+          "200": {
+            "description": "Entities were deleted successfully",
+            "content": {
+              "*/*": {
+                "schema": {
+                  "type": "object"
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+  }
+}