[FE][Part 2] Rename Semi-breaking chang

Author: Iurii Golovinskii

package-lock.json

@@ -34,7 +34,7 @@
     "release-finish": "release-finish"
   },
   "dependencies": {
-    "@netcracker/qubership-apihub-api-diff": "1.0.4",
+    "@netcracker/qubership-apihub-api-diff": "feature-rename-label-semi-breaking-changes-two",
     "@netcracker/qubership-apihub-api-unifier": "1.0.4",
     "@netcracker/qubership-apihub-json-crawl": "1.0.4",
     "@netcracker/qubership-apihub-graphapi": "1.0.8",

package.json

@@ -16,7 +16,14 @@
 
 import { RestOperationData, VersionRestOperation } from './rest.types'
 import { areDeprecatedOriginsNotEmpty, isOperationRemove, removeComponents } from '../../utils'
-import { apiDiff, breaking, COMPARE_MODE_OPERATION, Diff, DiffAction, semiBreaking } from '@netcracker/qubership-apihub-api-diff'
+import {
+  apiDiff,
+  breaking,
+  COMPARE_MODE_OPERATION,
+  Diff,
+  DiffAction,
+  risky,
+} from '@netcracker/qubership-apihub-api-diff'
 import { MESSAGE_SEVERITY, NORMALIZE_OPTIONS, ORIGINS_SYMBOL } from '../../consts'
 import { BREAKING_CHANGE_TYPE, CompareOperationsPairContext, SEMI_BREAKING_CHANGE_TYPE } from '../../types'
 import { isObject } from '@netcracker/qubership-apihub-json-crawl'
@@ -85,7 +92,7 @@ async function reclassifyBreakingChanges(
     const deprecatedInVersionsCount = previousOperation?.deprecatedInPreviousVersions?.length ?? 0
     if (isOperationRemove(diff) && deprecatedInVersionsCount > 1) {
       console.log('Тутэн')
-      diff.type = semiBreaking
+      diff.type = risky
       continue
     }
 
@@ -96,7 +103,7 @@ async function reclassifyBreakingChanges(
     if (!isObject(diff.beforeNormalizedValue)) {
       ctx.notifications.push({
         severity: MESSAGE_SEVERITY.Error,
-        message: '[Semi-breaking validation] Something wrong with beforeNormalizedValue from diff',
+        message: '[Risky validation] Something wrong with beforeNormalizedValue from diff',
       })
       continue
     }
@@ -105,7 +112,7 @@ async function reclassifyBreakingChanges(
     if (!areDeprecatedOriginsNotEmpty(diff.beforeNormalizedValue)) {
       ctx.notifications.push({
         severity: MESSAGE_SEVERITY.Error,
-        message: '[Semi-breaking validation] Something wrong with origins',
+        message: '[Risky validation] Something wrong with origins',
       })
       continue
     }
@@ -128,16 +135,20 @@ async function reclassifyBreakingChanges(
     }
 
     if (deprecatedItem && deprecatedItem?.deprecatedInPreviousVersions?.length > 1) {
-      diff.type = semiBreaking
+      diff.type = risky
     }
   }
+
+
   // mark removed required status of the property as semi-breaking
   if (diffs.length) {
     const requiredProperties = findRequiredRemovedProperties(mergedJso, diffs)
+    //console.log('requiredProperties----->', requiredProperties)
 
     requiredProperties?.forEach(prop => {
+   //   console.log('requiredProperties----->', prop.propDiff)
       if (prop.propDiff.type === SEMI_BREAKING_CHANGE_TYPE && prop.requiredDiff?.type === BREAKING_CHANGE_TYPE) {
-        prop.requiredDiff.type = semiBreaking
+        prop.requiredDiff.type = risky
       }
     })
   }

src/apitypes/rest/rest.changes.ts

@@ -21,3 +21,4 @@ export * from './components'
 export * from './consts'
 export * from './types'
 export { calculateChangeId, calculateDiffId, calculateImpactedSummary, convertToSlug, removeComponents } from './utils'
+console.log('dfsfsdfsdfsdf TEST')

src/index.ts

@@ -16,7 +16,7 @@
 
 import { ApiAudience } from '../package'
 import { OperationsApiType, PackageId, VersionId } from './types'
-import { ClassifierType, DiffType } from '@netcracker/qubership-apihub-api-diff'
+import { ClassifierType, DiffType, risky } from '@netcracker/qubership-apihub-api-diff'
 
 export type VersionComparisonResolver = (
   version: VersionId,
@@ -48,7 +48,7 @@ export interface OperationType {
 export const BREAKING_CHANGE_TYPE = 'breaking'
 export const NON_BREAKING_CHANGE_TYPE = 'non-breaking'
 export const UNCLASSIFIED_CHANGE_TYPE = 'unclassified'
-export const SEMI_BREAKING_CHANGE_TYPE = 'semi-breaking'
+export const SEMI_BREAKING_CHANGE_TYPE = risky
 export const DEPRECATED_CHANGE_TYPE = 'deprecated'
 export const ANNOTATION_CHANGE_TYPE = 'annotation'