Skip to content

Commit a0d5886

Browse files
committed
fix: remove includeSummary flag to avoid direct dashboards comparison
1 parent 6df0335 commit a0d5886

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

src/builder.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -277,8 +277,7 @@ export class PackageVersionBuilder implements IPackageVersionBuilder {
277277
version?: string,
278278
packageId?: string,
279279
operationIds?: OperationId[],
280-
includeData: boolean = true,
281-
operationsCount?: number,
280+
includeData = true,
282281
): Promise<ResolvedOperations | null> {
283282
if (!version) {
284283
return null
@@ -305,7 +304,6 @@ export class PackageVersionBuilder implements IPackageVersionBuilder {
305304
packageId,
306305
operationIds,
307306
includeData,
308-
operationsCount,
309307
)
310308

311309
// validate for missing operationData
@@ -403,10 +401,8 @@ export class PackageVersionBuilder implements IPackageVersionBuilder {
403401
async versionResolver(
404402
version: string,
405403
packageId: string,
406-
includeOperations?: boolean,
407-
includeSummary?: boolean,
408404
): Promise<VersionCache | null> {
409-
const compositeKey = getCompositeKey(packageId, version, String(includeOperations), String(includeSummary))
405+
const compositeKey = getCompositeKey(packageId, version)
410406

411407
if (this.canBeResolvedLocally(version, packageId)) {
412408
return this.currentVersion
@@ -422,7 +418,7 @@ export class PackageVersionBuilder implements IPackageVersionBuilder {
422418
throw new Error('No versionResolver provided')
423419
}
424420

425-
const versionContent = await versionResolver(packageId, version, includeOperations, includeSummary)
421+
const versionContent = await versionResolver(packageId, version)
426422

427423
if (!versionContent) {
428424
this.notifications.push({

src/components/compare/compare.operations.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ export async function compareVersionsOperations(
6666
const { versionResolver } = ctx
6767

6868
// resolve all version with operation hashes
69-
const prevVersionData = prev && (await versionResolver(...prev, false, true) ?? { version: prev?.[0], packageId: prev?.[1] })
70-
const currVersionData = curr && (await versionResolver(...curr, false, true) ?? { version: curr?.[0], packageId: curr?.[1] })
69+
const prevVersionData = prev && (await versionResolver(...prev) ?? { version: prev?.[0], packageId: prev?.[1] })
70+
const currVersionData = curr && (await versionResolver(...curr) ?? { version: curr?.[0], packageId: curr?.[1] })
7171

7272
// compare operations of each type
7373
for (const apiType of getUniqueApiTypesFromVersions(prevVersionData, currVersionData)) {

src/types/internal/apiBuilder.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,7 @@ export interface ApiBuilder<T = any, O = any, M = any> {
9999
}
100100

101101
// internal
102-
export type _VersionResolver = (
103-
packageId: PackageId,
104-
version: VersionId,
105-
includeOperations?: boolean,
106-
includeSummary?: boolean,
107-
) => Promise<VersionCache | null>
102+
export type _VersionResolver = (packageId: PackageId, version: VersionId) => Promise<VersionCache | null>
108103
export type _VersionReferencesResolver = (packageId: PackageId, version: VersionId) => Promise<BuildConfigRef[]>
109104

110105
export type _ParsedFileResolver = (fileId: string) => Promise<File | null>

0 commit comments

Comments
 (0)