review, fixed types

Author: Iurii Golovinskii

src/types/external/comparison.ts

@@ -45,7 +45,7 @@ export interface ResolvedComparisonSummary {
   operationTypes: OperationType[]
 }
 
-export interface OperationType<T extends string | number | symbol = DiffType> {
+export interface OperationType<T extends DiffType | DiffTypeDto = DiffType> {
   apiType: OperationsApiType
   changesSummary: ChangeSummary<T>
   numberOfImpactedOperations: ChangeSummary<T>
@@ -61,7 +61,7 @@ export const DEPRECATED_CHANGE_TYPE = deprecated
 export const ANNOTATION_CHANGE_TYPE = annotation
 export const SEMI_BREAKING_CHANGE_TYPE = 'semi-breaking'
 
-export type ChangeSummary<T extends string | number | symbol = DiffType> = Record<T, number>
+export type ChangeSummary<T extends DiffType | DiffTypeDto = DiffType> = Record<T, number>
 export type ImpactedOperationSummary = Record<DiffType, boolean>
 export const DIFF_TYPES: DiffType[] = Object.values(ClassifierType)
 

src/utils/transformToDto.ts

@@ -162,8 +162,8 @@ export function toVersionsComparisonDto({
 }
 
 export function convertDtoFieldOperationTypes<
-  T extends string | number | symbol = DiffTypeDto,
-  J extends string | number | symbol = DiffType>
+  T extends DiffTypeDto | DiffType = DiffTypeDto,
+  J extends DiffTypeDto | DiffType = DiffType>
 (operationTypes: ReadonlyArray<OperationType<T>>, {
   origin,
   override,
@@ -184,8 +184,8 @@ export function convertDtoFieldOperationTypes<
 }
 
 export function replacePropertyInChangesSummary<
-  T extends string | number | symbol = DiffTypeDto,
-  J extends string | number | symbol = DiffType>
+  T extends DiffTypeDto | DiffType = DiffTypeDto,
+  J extends DiffTypeDto | DiffType = DiffType>
 (obj: ChangeSummary<T>,
   {
     origin,

test/performance.ts

@@ -44,4 +44,4 @@ await portal.publish('performance', {
         { fileId: '2024.1/openapi_large_x6.yaml' },
     ],
 })
-console.log('DONE')
+console.log('DONE')

test/risky-changes.test.ts

@@ -54,14 +54,10 @@ describe('Risky changes test', () => {
 
     expect(result).toEqual(changesSummaryMatcher({
       [NON_BREAKING_CHANGE_TYPE]: 1,
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
       [RISKY_CHANGE_TYPE]: 1,
     }))
     expect(result).toEqual(numberOfImpactedOperationsMatcher({
       [NON_BREAKING_CHANGE_TYPE]: 1,
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
       [RISKY_CHANGE_TYPE]: 1,
     }))
   })
@@ -100,14 +96,10 @@ describe('Risky changes test', () => {
 
     expect(result).toEqual(changesSummaryMatcher({
       [BREAKING_CHANGE_TYPE]: 1,
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
       [RISKY_CHANGE_TYPE]: 1,
     }))
     expect(result).toEqual(numberOfImpactedOperationsMatcher({
       [BREAKING_CHANGE_TYPE]: 1,
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
       [RISKY_CHANGE_TYPE]: 1,
     }))
   })
@@ -143,13 +135,9 @@ describe('Risky changes test', () => {
     const result = await editor.run()
 
     expect(result).toEqual(changesSummaryMatcher({
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
       [RISKY_CHANGE_TYPE]: 2,
     }))
     expect(result).toEqual(numberOfImpactedOperationsMatcher({
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
       [RISKY_CHANGE_TYPE]: 2,
     }))
   })
@@ -185,14 +173,10 @@ describe('Risky changes test', () => {
     const result = await editor.run()
 
     expect(result).toEqual(changesSummaryMatcher({
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
       [RISKY_CHANGE_TYPE]: 3,
       [NON_BREAKING_CHANGE_TYPE]: 1,
     }))
     expect(result).toEqual(numberOfImpactedOperationsMatcher({
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
       [RISKY_CHANGE_TYPE]: 1,
       [NON_BREAKING_CHANGE_TYPE]: 1,
     }))