Skip to content

Commit c85d4f8

Browse files
committed
fix: do not call resolvers for falsy versions when building a changelog
1 parent 5b293a1 commit c85d4f8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/components/compare/compare.operations.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ async function compareCurrentApiType(
117117
const { version: prevVersion, packageId: prevPackageId } = prev ?? { version: '', packageId: '' }
118118
const { version: currVersion, packageId: currPackageId } = curr ?? { version: '', packageId: '' }
119119

120-
const { operations: prevOperations = [] } = await versionOperationsResolver(apiType, prevVersion, prevPackageId, undefined, false) || {}
121-
const { operations: currOperations = [] } = await versionOperationsResolver(apiType, currVersion, currPackageId, undefined, false) || {}
120+
const { operations: prevOperations = [] } = prev && await versionOperationsResolver(apiType, prevVersion, prevPackageId, undefined, false) || {}
121+
const { operations: currOperations = [] } = curr && await versionOperationsResolver(apiType, currVersion, currPackageId, undefined, false) || {}
122122

123123
const previousGroupSlug = convertToSlug(previousGroup)
124124
const currentGroupSlug = convertToSlug(currentGroup)

src/components/compare/compare.utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,8 @@ export const calculatePairedDocs = async (
217217
currentPackageId,
218218
} = ctx
219219

220-
const { documents: prevDocuments } = await versionDocumentsResolver(previousVersion, previousPackageId, apiType) ?? { documents: [] }
221-
const { documents: currDocuments } = await versionDocumentsResolver(currentVersion, currentPackageId, apiType) ?? { documents: [] }
220+
const { documents: prevDocuments } = previousVersion && await versionDocumentsResolver(previousVersion, previousPackageId, apiType) || { documents: [] }
221+
const { documents: currDocuments } = currentVersion && await versionDocumentsResolver(currentVersion, currentPackageId, apiType) || { documents: [] }
222222

223223
const pairedDocs: [ResolvedVersionDocument | undefined, ResolvedVersionDocument | undefined][] = []
224224
for (const { previous, current } of operationPairs) {

0 commit comments

Comments
 (0)