refactor: cleanup

Author: CountRedClaw

src/components/compare/compare.operations.ts

@@ -150,11 +150,10 @@ async function compareCurrentApiType(
 
   const apiAudienceTransitions: ApiAudienceTransition[] = []
   // todo: convert from objects analysis to apihub-diff result analysis after the "info" section participates in the comparison of operations
-  syncDebugPerformance('[ApiAudience]', () => {
-    operationPairs.forEach(({current, previous}) => {
-      calculateApiAudienceTransitions(current, previous, apiAudienceTransitions)
-    })
-  }, debugCtx)
+  syncDebugPerformance('[ApiAudience]',
+    () => operationPairs.forEach((pair) => calculateApiAudienceTransitions(pair, apiAudienceTransitions)),
+    debugCtx,
+  )
 
   return [
     {

src/types/internal/apiBuilder.ts

@@ -113,11 +113,6 @@ export type DocumentsCompare = (operationsMap: OperationsMap, currDoc: ResolvedV
   operationChanges: OperationChanges[]
   tags: string[]
 }>
-export type OperationChangesValidator = (
-  changes: ChangeMessage, // + ctx with internal resolvers
-  previousOperation?: RestOperationData, // TODO remove
-  prePreviousOperation?: RestOperationData, // TODO remove
-) => boolean
 export type OperationIdNormalizer = (operation: ResolvedOperation) => NormalizedOperationId
 export type DocumentExporter = (
   filename: string,
@@ -141,7 +136,6 @@ export interface ApiBuilder<T = any, O = any, M = any> {
   buildOperations?: OperationsBuilder<T, M>
   compareOperationsData?: OperationDataCompare<O>
   compareDocuments?: DocumentsCompare
-  validateOperationChanges?: OperationChangesValidator
   createNormalizedOperationId?: OperationIdNormalizer
   createExportDocument?: DocumentExporter
 }

src/utils/builder.ts

@@ -29,6 +29,7 @@ import {
 import { API_KIND } from '../consts'
 import { Diff, DiffType } from '@netcracker/qubership-apihub-api-diff'
 import { JsonPath } from '@netcracker/qubership-apihub-json-crawl'
+import { OperationPair } from '../components'
 
 export type ObjPath = (string | number)[]
 
@@ -175,12 +176,12 @@ export const rawToApiKind = (apiKindLike: string): ApiKind => {
 }
 
 export const calculateApiAudienceTransitions = (
-  currentOperation: ResolvedOperation | undefined,
-  previousOperation: ResolvedOperation | undefined,
+  operationPair: OperationPair,
   apiAudienceTransitions: ApiAudienceTransition[],
 ): void => {
-  const currentAudience = currentOperation?.apiAudience
-  const previousAudience = previousOperation?.apiAudience
+  const { previous, current } = operationPair
+  const previousAudience = previous?.apiAudience
+  const currentAudience = current?.apiAudience
   if (!currentAudience || !previousAudience) {
     return
   }