fixed tests

Author: Iurii Golovinskii

test/apiKinds.test.ts

@@ -145,9 +145,8 @@ describe('Semi-breaking changes for no-bwc operations test', () => {
     }, {}, portal)
 
     const result = await editor.run()
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
-    expect(result.comparisons[0].operationTypes[0].changesSummary?.[SEMI_BREAKING_CHANGE_TYPE]).toBe(3)
+
+    expect(result.comparisons[0].operationTypes[0].changesSummary?.[RISKY_CHANGE_TYPE]).toBe(3)
   })
 
   test('should have 1 breaking change', async () => {

test/declarative-changes-in-rest-package-version.test.ts

@@ -56,11 +56,11 @@ describe('Number of declarative changes in rest package version test', () => {
     const result = await buildChangelogPackage('declarative-changes-in-rest-package-version/case5')
     expect(result).toEqual(changesSummaryMatcher({
       [BREAKING_CHANGE_TYPE]: 1,
-      [SEMI_BREAKING_CHANGE_TYPE]: 1,
+      [RISKY_CHANGE_TYPE]: 1,
     }))
     expect(result).toEqual(numberOfImpactedOperationsMatcher({
       [BREAKING_CHANGE_TYPE]: 1,
-      [SEMI_BREAKING_CHANGE_TYPE]: 1,
+      [RISKY_CHANGE_TYPE]: 1,
     }))
   })
 })

test/deprecated.test.ts

@@ -91,7 +91,7 @@ describe('Deprecated Items test', () => {
     const result = await editor.run()
     // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
-    expect(result.comparisons[0].operationTypes[0].changesSummary?.[SEMI_BREAKING_CHANGE_TYPE]).toBe(1)
+    expect(result.comparisons[0].operationTypes[0].changesSummary?.[RISKY_CHANGE_TYPE]).toBe(1)
     expect(result.comparisons[0].operationTypes[0].changesSummary?.[BREAKING_CHANGE_TYPE]).toBe(0)
   })
 
@@ -107,6 +107,6 @@ describe('Deprecated Items test', () => {
     const result = await editor.run()
     // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
-    expect(result.comparisons[0].operationTypes[0].changesSummary?.[SEMI_BREAKING_CHANGE_TYPE]).toBe(4)
+    expect(result.comparisons[0].operationTypes[0].changesSummary?.[RISKY_CHANGE_TYPE]).toBe(4)
   })
 })

test/graphql.test.ts

@@ -57,7 +57,7 @@ describe('GraphQL test', () => {
       ],
     })
 
-    const changes = result.comparisons[0].data?.flatMap(data => data.changes)
+    const changes = result.comparisons[0].data?.flatMap(data => data.diffs)
 
     expect(changes?.length).toBeTruthy()
     expect(changes?.every(change => change?.description)).toBeTruthy()

test/helpers/matchers.ts

@@ -17,9 +17,8 @@
 import {
   ChangeMessage,
   ChangeSummary,
-  ChangeSummaryDto,
   DeprecateItem,
-  EMPTY_CHANGE_SUMMARY_DTO,
+  EMPTY_CHANGE_SUMMARY,
   OperationChanges,
   type OperationsApiType,
   OperationType,
@@ -56,26 +55,26 @@ export function apihubOperationChangesMatcher(
 }
 
 export function changesSummaryMatcher(
-  expected: Partial<ChangeSummaryDto>,
+  expected: Partial<ChangeSummary>,
   apiType: OperationsApiType = REST_API_TYPE,
 ): ApihubChangesSummaryMatcher {
   return operationTypeMatcher({
     apiType: apiType,
     changesSummary: expect.objectContaining({
-      ...EMPTY_CHANGE_SUMMARY_DTO,
+      ...EMPTY_CHANGE_SUMMARY,
       ...expected,
     }),
   })
 }
 
 export function numberOfImpactedOperationsMatcher(
-  expected: Partial<ChangeSummaryDto>,
+  expected: Partial<ChangeSummary>,
   apiType: OperationsApiType = REST_API_TYPE,
 ): ApihubChangesSummaryMatcher {
   return operationTypeMatcher({
     apiType: apiType,
     numberOfImpactedOperations: expect.objectContaining({
-      ...EMPTY_CHANGE_SUMMARY_DTO,
+      ...EMPTY_CHANGE_SUMMARY,
       ...expected,
     }),
   })

test/helpers/registry/apihub.ts

@@ -22,7 +22,7 @@ import {
   BuilderContext,
   BuilderResolvers,
   BuildResult,
-  graphqlApiBuilder,
+  graphqlApiBuilder, MESSAGE_SEVERITY,
   OperationId,
   OperationsApiType,
   PackageId,
@@ -51,6 +51,7 @@ import {
   saveNotifications,
   saveOperationsArray,
 } from './utils'
+import { toVersionsComparisonDto } from '../../../src/utils/transformToDto'
 
 export const VERSIONS_PATH = 'test/versions'
 
@@ -106,6 +107,14 @@ export class ApihubRegistry implements IRegistry {
     } catch (e) {
       // do nothing
     }
+
+    const logError = (message: string): void => {
+      notifications.push({
+        severity: MESSAGE_SEVERITY.Error,
+        message: message,
+      })
+    }
+
     await fs.mkdir(basePath, { recursive: true })
 
     await saveInfo(config, basePath)
@@ -115,9 +124,9 @@ export class ApihubRegistry implements IRegistry {
 
     await saveOperationsArray(operations, basePath)
     await saveEachOperation(operations, basePath)
-
-    await saveComparisonsArray(comparisons, basePath)
-    await saveEachComparison(comparisons, basePath)
+    const comparisonsDto = comparisons.map(comparison => toVersionsComparisonDto(comparison, logError))
+    await saveComparisonsArray(comparisonsDto, basePath)
+    await saveEachComparison(comparisonsDto, basePath)
     await saveNotifications(notifications, basePath)
   }
 

test/helpers/registry/local.ts

@@ -26,7 +26,7 @@ import {
   EMPTY_CHANGE_SUMMARY, EMPTY_CHANGE_SUMMARY_DTO,
   FILE_FORMAT,
   GRAPHQL_API_TYPE,
-  graphqlApiBuilder,
+  graphqlApiBuilder, MESSAGE_SEVERITY,
   NotificationMessage,
   OperationId,
   OperationsApiType,
@@ -71,6 +71,7 @@ import { getCompositeKey, getSplittedVersionKey, isNotEmpty, toBase64 } from '..
 import { groupBy } from 'graphql/jsutils/groupBy'
 import { IRegistry } from './types'
 import { calculateTotalChangeSummary } from '../../../src/components/compare'
+import { toVersionsComparisonDto } from '../../../src/utils/transformToDto'
 
 const VERSIONS_PATH = 'test/versions'
 const DEFAULT_PROJECTS_PATH = 'test/projects'
@@ -366,8 +367,15 @@ export class LocalRegistry implements IRegistry {
     await saveOperationsArray(operations, basePath)
     await saveEachOperation(operations, basePath)
 
-    await saveComparisonsArray(comparisons, basePath)
-    await saveEachComparison(comparisons, basePath)
+    const logError = (message: string): void => {
+      notifications.push({
+        severity: MESSAGE_SEVERITY.Error,
+        message: message,
+      })
+    }
+    const comparisonsDto = comparisons.map(comparison => toVersionsComparisonDto(comparison, logError))
+    await saveComparisonsArray(comparisonsDto, basePath)
+    await saveEachComparison(comparisonsDto, basePath)
     await saveNotifications(notifications, basePath)
   }
 

test/semi-breaking-changes.test.ts

@@ -15,13 +15,7 @@
  */
 
 import { changesSummaryMatcher, Editor, LocalRegistry, numberOfImpactedOperationsMatcher } from './helpers'
-import {
-  BREAKING_CHANGE_TYPE,
-  BUILD_TYPE,
-  NON_BREAKING_CHANGE_TYPE,
-  SEMI_BREAKING_CHANGE_TYPE,
-  VERSION_STATUS,
-} from '../src'
+import { BREAKING_CHANGE_TYPE, BUILD_TYPE, NON_BREAKING_CHANGE_TYPE, RISKY_CHANGE_TYPE, VERSION_STATUS } from '../src'
 
 const portal = new LocalRegistry('new-deprecated')
 
@@ -62,13 +56,13 @@ describe('Semi-breaking changes test', () => {
       [NON_BREAKING_CHANGE_TYPE]: 1,
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
-      [SEMI_BREAKING_CHANGE_TYPE]: 1,
+      [RISKY_CHANGE_TYPE]: 1,
     }))
     expect(result).toEqual(numberOfImpactedOperationsMatcher({
       [NON_BREAKING_CHANGE_TYPE]: 1,
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
-      [SEMI_BREAKING_CHANGE_TYPE]: 1,
+      [RISKY_CHANGE_TYPE]: 1,
     }))
   })
 
@@ -108,13 +102,13 @@ describe('Semi-breaking changes test', () => {
       [BREAKING_CHANGE_TYPE]: 1,
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
-      [SEMI_BREAKING_CHANGE_TYPE]: 1,
+      [RISKY_CHANGE_TYPE]: 1,
     }))
     expect(result).toEqual(numberOfImpactedOperationsMatcher({
       [BREAKING_CHANGE_TYPE]: 1,
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
-      [SEMI_BREAKING_CHANGE_TYPE]: 1,
+      [RISKY_CHANGE_TYPE]: 1,
     }))
   })
 
@@ -151,12 +145,12 @@ describe('Semi-breaking changes test', () => {
     expect(result).toEqual(changesSummaryMatcher({
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
-      [SEMI_BREAKING_CHANGE_TYPE]: 2,
+      [RISKY_CHANGE_TYPE]: 2,
     }))
     expect(result).toEqual(numberOfImpactedOperationsMatcher({
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
-      [SEMI_BREAKING_CHANGE_TYPE]: 2,
+      [RISKY_CHANGE_TYPE]: 2,
     }))
   })
 
@@ -193,13 +187,13 @@ describe('Semi-breaking changes test', () => {
     expect(result).toEqual(changesSummaryMatcher({
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
-      [SEMI_BREAKING_CHANGE_TYPE]: 3,
+      [RISKY_CHANGE_TYPE]: 3,
       [NON_BREAKING_CHANGE_TYPE]: 1,
     }))
     expect(result).toEqual(numberOfImpactedOperationsMatcher({
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
-      [SEMI_BREAKING_CHANGE_TYPE]: 1,
+      [RISKY_CHANGE_TYPE]: 1,
       [NON_BREAKING_CHANGE_TYPE]: 1,
     }))
   })