Skip to content

Commit e0d7495

Browse files
committed
fix: review remarks
1 parent efc9dd3 commit e0d7495

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

src/builder.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,14 @@ import {
5151
import type { NotificationMessage, PackageConfig } from './types/package'
5252
import { graphqlApiBuilder, REST_API_TYPE, restApiBuilder, textApiBuilder, unknownApiBuilder } from './apitypes'
5353
import { filesDiff, findSharedPath, getCompositeKey, getFileExtension, getOperationsList } from './utils'
54-
import { BUILD_TYPE, DEFAULT_BATCH_SIZE, MESSAGE_SEVERITY, SUPPORTED_FILE_FORMATS, VERSION_STATUS } from './consts'
54+
import {
55+
BUILD_TYPE,
56+
DEFAULT_BATCH_SIZE,
57+
DEFAULT_VALIDATION_RULES_SEVERITY_CONFIG,
58+
MESSAGE_SEVERITY,
59+
SUPPORTED_FILE_FORMATS,
60+
VERSION_STATUS,
61+
} from './consts'
5562
import { unknownParsedFile } from './apitypes/unknown/unknown.parser'
5663
import { createVersionPackage } from './components/package'
5764
import { compareVersions } from './components/compare'
@@ -96,7 +103,7 @@ export class PackageVersionBuilder implements IPackageVersionBuilder {
96103
previousVersionPackageId: '',
97104
...config,
98105
validationRulesSeverity: {
99-
brokenRefs: VALIDATION_RULES_SEVERITY_LEVEL_WARNING,
106+
...DEFAULT_VALIDATION_RULES_SEVERITY_CONFIG,
100107
...config.validationRulesSeverity,
101108
},
102109
}

src/consts.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,16 @@ import {
2323
NON_BREAKING_CHANGE_TYPE,
2424
SEMI_BREAKING_CHANGE_TYPE,
2525
UNCLASSIFIED_CHANGE_TYPE,
26+
VALIDATION_RULES_SEVERITY_LEVEL_WARNING,
27+
ValidationRulesSeverity,
2628
} from './types'
2729

2830
export const DEFAULT_BATCH_SIZE = 32
2931

32+
export const DEFAULT_VALIDATION_RULES_SEVERITY_CONFIG: ValidationRulesSeverity = {
33+
brokenRefs: VALIDATION_RULES_SEVERITY_LEVEL_WARNING,
34+
}
35+
3036
export const REVISION_DELIMITER = '@'
3137

3238
export const VERSION_DIFFERENCE_ACTION = {

src/utils/document.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ export const createBundlingErrorHandler = (ctx: BuilderContext, fileId: FileId)
126126
case VALIDATION_RULES_SEVERITY_LEVEL_ERROR:
127127
throw new Error(messages[0])
128128
case VALIDATION_RULES_SEVERITY_LEVEL_WARNING:
129+
default:
129130
for (const message of messages) {
130131
ctx.notifications.push({
131132
severity: MESSAGE_SEVERITY.Error,

0 commit comments

Comments
 (0)