Skip to content

Commit 31b327e

Browse files
committed
chore: merge from feature/rename-label-semi-breaking-changes to develop
2 parents e7c62d4 + ce49ac8 commit 31b327e

File tree

8 files changed

+9
-9
lines changed

8 files changed

+9
-9
lines changed

src/packages/portal/pages/PortalPage/ComparisonPages/BaseCompareToolbar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export abstract class BaseCompareToolbar {
99
readonly backBtn = new Button(this.locator.getByTestId('BackButton'), 'Back')
1010
readonly packageSlt = new ComparisonPagePackageSelect(this.page)
1111
readonly breakingChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-breaking'), 'Breaking changes filter')
12-
readonly semiBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-semi-breaking'), 'Semi-breaking changes filter')
12+
readonly semiBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-semi-breaking'), 'Risky changes filter')
1313
readonly deprecatedChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-deprecated'), 'Deprecated changes filter')
1414
readonly nonBreakingChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-non-breaking'), 'Non-breaking changes filter')
1515
readonly annotationChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-annotation'), 'Annotation changes filter')

src/packages/portal/pages/PortalPage/ComparisonPages/ComparePackagesPage/ComparePackagesContent/OperationChangesSummary.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export class OperationChangesSummary extends BaseComponent {
55

66
readonly componentType: string = 'changes summary'
77
readonly breaking = new Content(this.mainLocator.getByTestId('breaking'), `${this.componentName} Breaking changes`)
8-
readonly semiBreaking = new Content(this.mainLocator.getByTestId('semi-breaking'), `${this.componentName} Semi-breaking changes`)
8+
readonly semiBreaking = new Content(this.mainLocator.getByTestId('semi-breaking'), `${this.componentName} Risky changes`)
99
readonly deprecated = new Content(this.mainLocator.getByTestId('deprecated'), `${this.componentName} Deprecated changes`)
1010
readonly nonBreaking = new Content(this.mainLocator.getByTestId('non-breaking'), `${this.componentName} Non-breaking changes`)
1111
readonly annotation = new Content(this.mainLocator.getByTestId('annotation'), `${this.componentName} Annotation changes`)

src/packages/portal/pages/PortalPage/VersionPage/VersionOverviewTab/OverviewSummaryTab/OverviewSummaryTabBody/OverviewValidationsContent.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export class OverviewValidationsContent {
88
readonly noBwcOperations = new Content(this.locator.getByTestId('NumberOfNoBwcOperationsTypography'), 'Number of no-BWC operations')
99
readonly bwcErrors = new Content(this.locator.getByTestId('NumberOfBwcErrorsTypography'), 'Number of BWC errors')
1010
readonly breakingChanges = new Content(this.locator.getByTestId('breaking'), 'Breaking changes')
11-
readonly semiBreakingChanges = new Content(this.locator.getByTestId('semi-breaking'), 'Semi-breaking changes')
11+
readonly semiBreakingChanges = new Content(this.locator.getByTestId('semi-breaking'), 'Risky changes')
1212
readonly deprecatedChanges = new Content(this.locator.getByTestId('deprecated'), 'Deprecated changes')
1313
readonly nonBreakingChanges = new Content(this.locator.getByTestId('non-breaking'), 'Non-breaking changes')
1414
readonly annotationChanges = new Content(this.locator.getByTestId('annotation'), 'Annotation changes')

src/packages/portal/pages/PortalPage/VersionPage/VersionPackagePage/PackageTabToolbar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export class PackageTabToolbar {
88
readonly comparedToLnk = new Link(this.page.getByTestId('ComparedToLink'), 'Compared to')
99
readonly sltApiType = new ApiTypeSelect(this.page)
1010
readonly breakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-breaking'), 'Breaking changes filter')
11-
readonly semiBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-semi-breaking'), 'Semi-breaking changes filter')
11+
readonly semiBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-semi-breaking'), 'Risky changes filter')
1212
readonly deprecatedChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-deprecated'), 'Deprecated changes filter')
1313
readonly nonBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-non-breaking'), 'Non-breaking changes filter')
1414
readonly annotationChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-annotation'), 'Annotation changes filter')

src/packages/shared/components/custom/table-cells/ChangesTableCell.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export class ChangesTableCell extends TableCell {
66
readonly breakingChanges = new Content(this.mainLocator.getByTestId('breaking'), 'Breaking changes')
77
readonly deprecatedChanges = new Content(this.mainLocator.getByTestId('deprecated'), 'Deprecated changes')
88
readonly nonBreakingChanges = new Content(this.mainLocator.getByTestId('non-breaking'), 'Non-breaking changes')
9-
readonly semiBreakingChanges = new Content(this.mainLocator.getByTestId('semi-breaking'), 'Semi-breaking changes')
9+
readonly semiBreakingChanges = new Content(this.mainLocator.getByTestId('semi-breaking'), 'Risky changes')
1010
readonly annotationChanges = new Content(this.mainLocator.getByTestId('annotation'), 'Annotation changes')
1111
readonly unclassifiedChanges = new Content(this.mainLocator.getByTestId('unclassified'), 'Unclassified changes')
1212

src/test-data/shared/messages.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ export const TOOLTIP_SEVERITY_MSG = {
22
breaking: 'Breaking change is a change that breaks backward compatibility with the previous version of API. For example, deleting an operation, adding a required parameter or changing type of a parameter are breaking changes.',
33
nonBreaking: 'Non-breaking change is change that does not break backward compatibility with the previous version of API. For example, adding new operation or optional parameter is non-breaking change.',
44
semiBreaking: [
5-
'Semi-breaking change is a change that breaks backward compatibility according to the rules:',
5+
'Risky change is a change that breaks backward compatibility according to the rules:',
66
'operation was annotated as deprecated in at least two previous consecutive releases and then it was deleted',
77
'operation is marked as no-BWC',
88
],

src/tests/portal/06-api-changes/6.1-api-changes-package.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ test.describe('6.1 API Changes (Package)', () => {
373373
await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.annotation!.description).changeSeverityIndicator).toHaveText('annotation')
374374
await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.unclassified!.description).changeSeverityIndicator).toHaveText('unclassified')
375375
await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.deprecated!.description).changeSeverityIndicator).toHaveText('deprecated')
376-
await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.semiBreaking!.description).changeSeverityIndicator).toHaveText('semi-breaking')
376+
await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.semiBreaking!.description).changeSeverityIndicator).toHaveText('risky')
377377
await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.nonBreaking!.description).changeSeverityIndicator).toHaveText('non-breaking')
378378
await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.breaking!.description).changeSeverityIndicator).toHaveText('breaking')
379379

@@ -383,7 +383,7 @@ test.describe('6.1 API Changes (Package)', () => {
383383

384384
await apiChangesTab.table.getOperationRow(DEL_ORDER_V1).expandBtn.click()
385385

386-
await expect.soft(apiChangesTab.table.getChangeDescriptionCell(DEL_ORDER_V1.changes!.semiBreaking!.description).changeSeverityIndicator).toHaveText('semi-breaking')
386+
await expect.soft(apiChangesTab.table.getChangeDescriptionCell(DEL_ORDER_V1.changes!.semiBreaking!.description).changeSeverityIndicator).toHaveText('risky')
387387
})
388388

389389
test('[P-CHPVW-5] Navigation to the Operation Compare page',

src/tests/portal/09-comparison/9.1-compare-package-versions.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ test.describe('09.1 Compare Package versions', () => {
637637
await expect.soft(updateUserRow.rightSummary.path).toHaveText(`${UPDATE_USER_V1.method}${UPDATE_USER_V1.path}`)
638638
await expect.soft(updateUserRow.rightSummary.changes.deprecated).toHaveText('1')
639639

640-
await expect.soft(delOrderRow.changeSeverityIndicator).toHaveText('semi-breaking')
640+
await expect.soft(delOrderRow.changeSeverityIndicator).toHaveText('risky')
641641
await expect.soft(delOrderRow.leftSummary.title).toHaveText(DEL_ORDER_V1.title)
642642
await expect.soft(delOrderRow.leftSummary.path).toHaveText(`${DEL_ORDER_V1.method}${DEL_ORDER_V1.path}`)
643643
await expect.soft(delOrderRow.leftSummary.changes).not.toBeVisible()

0 commit comments

Comments
 (0)