fix: rename 'risky' changes to 'requires attention'

Author: vOrigins

src/packages/portal/pages/PortalPage/ComparisonPages/BaseCompareToolbar.ts

@@ -8,12 +8,12 @@ export abstract class BaseCompareToolbar {
   readonly breadcrumbs = new Breadcrumbs(this.locator.getByTestId('ComparedPackagesBreadcrumbs'), 'Comparison')
   readonly backBtn = new Button(this.locator.getByTestId('BackButton'), 'Back')
   readonly packageSlt = new ComparisonPagePackageSelect(this.page)
-  readonly breakingChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-breaking'), 'Breaking changes filter')
-  readonly semiBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-semi-breaking'), 'Risky changes filter')
-  readonly deprecatedChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-deprecated'), 'Deprecated changes filter')
-  readonly nonBreakingChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-non-breaking'), 'Non-breaking changes filter')
-  readonly annotationChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-annotation'), 'Annotation changes filter')
-  readonly unclassifiedChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-unclassified'), 'Unclassified changes filter')
+  readonly breakingChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-breaking'), 'Breaking Сhanges filter')
+  readonly semiBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-semi-breaking'), 'Changes Requiring Attention filter')
+  readonly deprecatedChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-deprecated'), 'Deprecated Сhanges filter')
+  readonly nonBreakingChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-non-breaking'), 'Non-breaking Сhanges filter')
+  readonly annotationChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-annotation'), 'Annotation Сhanges filter')
+  readonly unclassifiedChangesFilterBtn = new Button(this.locator.getByTestId('ChangesFilterButton-unclassified'), 'Unclassified Сhanges filter')
 
   protected constructor(protected readonly page: Page) { }
 }

src/packages/portal/pages/PortalPage/ComparisonPages/ComparePackagesPage/ComparePackagesContent/OperationChangesSummary.ts

@@ -4,12 +4,12 @@ import { BaseComponent, Content } from '@shared/components/base'
 export class OperationChangesSummary extends BaseComponent {
 
   readonly componentType: string = 'changes summary'
-  readonly breaking = new Content(this.mainLocator.getByTestId('breaking'), `${this.componentName} Breaking changes`)
-  readonly semiBreaking = new Content(this.mainLocator.getByTestId('semi-breaking'), `${this.componentName} Risky changes`)
-  readonly deprecated = new Content(this.mainLocator.getByTestId('deprecated'), `${this.componentName} Deprecated changes`)
-  readonly nonBreaking = new Content(this.mainLocator.getByTestId('non-breaking'), `${this.componentName} Non-breaking changes`)
-  readonly annotation = new Content(this.mainLocator.getByTestId('annotation'), `${this.componentName} Annotation changes`)
-  readonly unclassified = new Content(this.mainLocator.getByTestId('unclassified'), `${this.componentName} Unclassified changes`)
+  readonly breaking = new Content(this.mainLocator.getByTestId('breaking'), `${this.componentName} Breaking Сhanges`)
+  readonly semiBreaking = new Content(this.mainLocator.getByTestId('semi-breaking'), `${this.componentName} Changes Requiring Attention`)
+  readonly deprecated = new Content(this.mainLocator.getByTestId('deprecated'), `${this.componentName} Deprecated Сhanges`)
+  readonly nonBreaking = new Content(this.mainLocator.getByTestId('non-breaking'), `${this.componentName} Non-breaking Сhanges`)
+  readonly annotation = new Content(this.mainLocator.getByTestId('annotation'), `${this.componentName} Annotation Сhanges`)
+  readonly unclassified = new Content(this.mainLocator.getByTestId('unclassified'), `${this.componentName} Unclassified Сhanges`)
 
   constructor(rootLocator: Locator, componentName?: string, componentType?: string) {
     super(rootLocator, componentName, componentType)

src/packages/portal/pages/PortalPage/VersionPage/VersionOverviewTab/OverviewSummaryTab/OverviewSummaryTabBody/OverviewValidationsContent.ts

@@ -7,12 +7,12 @@ export class OverviewValidationsContent {
   readonly deprecatedOperations = new Content(this.locator.getByTestId('NumberOfDeprecatedOperationsTypography'), 'Number of deprecated operations')
   readonly noBwcOperations = new Content(this.locator.getByTestId('NumberOfNoBwcOperationsTypography'), 'Number of no-BWC operations')
   readonly bwcErrors = new Content(this.locator.getByTestId('NumberOfBwcErrorsTypography'), 'Number of BWC errors')
-  readonly breakingChanges = new Content(this.locator.getByTestId('breaking'), 'Breaking changes')
-  readonly semiBreakingChanges = new Content(this.locator.getByTestId('semi-breaking'), 'Risky changes')
-  readonly deprecatedChanges = new Content(this.locator.getByTestId('deprecated'), 'Deprecated changes')
-  readonly nonBreakingChanges = new Content(this.locator.getByTestId('non-breaking'), 'Non-breaking changes')
-  readonly annotationChanges = new Content(this.locator.getByTestId('annotation'), 'Annotation changes')
-  readonly unclassifiedChanges = new Content(this.locator.getByTestId('unclassified'), 'Unclassified changes')
+  readonly breakingChanges = new Content(this.locator.getByTestId('breaking'), 'Breaking Сhanges')
+  readonly semiBreakingChanges = new Content(this.locator.getByTestId('semi-breaking'), 'Changes Requiring Attention')
+  readonly deprecatedChanges = new Content(this.locator.getByTestId('deprecated'), 'Deprecated Сhanges')
+  readonly nonBreakingChanges = new Content(this.locator.getByTestId('non-breaking'), 'Non-breaking Сhanges')
+  readonly annotationChanges = new Content(this.locator.getByTestId('annotation'), 'Annotation Сhanges')
+  readonly unclassifiedChanges = new Content(this.locator.getByTestId('unclassified'), 'Unclassified Сhanges')
 
   constructor(private readonly locator: Locator) { }
 }

src/packages/portal/pages/PortalPage/VersionPage/VersionPackagePage/PackageTabToolbar.ts

@@ -7,12 +7,12 @@ export class PackageTabToolbar {
 
   readonly comparedToLnk = new Link(this.page.getByTestId('ComparedToLink'), 'Compared to')
   readonly sltApiType = new ApiTypeSelect(this.page)
-  readonly breakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-breaking'), 'Breaking changes filter')
-  readonly semiBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-semi-breaking'), 'Risky changes filter')
-  readonly deprecatedChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-deprecated'), 'Deprecated changes filter')
-  readonly nonBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-non-breaking'), 'Non-breaking changes filter')
-  readonly annotationChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-annotation'), 'Annotation changes filter')
-  readonly unclassifiedChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-unclassified'), 'Unclassified changes filter')
+  readonly breakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-breaking'), 'Breaking Сhanges filter')
+  readonly semiBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-semi-breaking'), 'Changes Requiring Attention filter')
+  readonly deprecatedChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-deprecated'), 'Deprecated Сhanges filter')
+  readonly nonBreakingChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-non-breaking'), 'Non-breaking Сhanges filter')
+  readonly annotationChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-annotation'), 'Annotation Сhanges filter')
+  readonly unclassifiedChangesFilterBtn = new Button(this.page.getByTestId('ChangesFilterButton-unclassified'), 'Unclassified Сhanges filter')
   readonly searchbar = new SearchBar(this.page.getByTestId('SearchOperations'), 'Operations')
   readonly filtersBtn = new Button(this.page.getByTestId('FiltersButton'), 'Filters')
   readonly listViewBtn = new Button(this.page.locator('button[value=list]'), 'List View')

src/packages/shared/components/custom/table-cells/ChangesTableCell.ts

@@ -3,12 +3,12 @@ import { Content, TableCell } from '@shared/components/base'
 
 export class ChangesTableCell extends TableCell {
 
-  readonly breakingChanges = new Content(this.mainLocator.getByTestId('breaking'), 'Breaking changes')
-  readonly deprecatedChanges = new Content(this.mainLocator.getByTestId('deprecated'), 'Deprecated changes')
-  readonly nonBreakingChanges = new Content(this.mainLocator.getByTestId('non-breaking'), 'Non-breaking changes')
-  readonly semiBreakingChanges = new Content(this.mainLocator.getByTestId('semi-breaking'), 'Risky changes')
-  readonly annotationChanges = new Content(this.mainLocator.getByTestId('annotation'), 'Annotation changes')
-  readonly unclassifiedChanges = new Content(this.mainLocator.getByTestId('unclassified'), 'Unclassified changes')
+  readonly breakingChanges = new Content(this.mainLocator.getByTestId('breaking'), 'Breaking Сhanges')
+  readonly deprecatedChanges = new Content(this.mainLocator.getByTestId('deprecated'), 'Deprecated Сhanges')
+  readonly nonBreakingChanges = new Content(this.mainLocator.getByTestId('non-breaking'), 'Non-breaking Сhanges')
+  readonly semiBreakingChanges = new Content(this.mainLocator.getByTestId('semi-breaking'), 'Changes Requiring Attention')
+  readonly annotationChanges = new Content(this.mainLocator.getByTestId('annotation'), 'Annotation Сhanges')
+  readonly unclassifiedChanges = new Content(this.mainLocator.getByTestId('unclassified'), 'Unclassified Сhanges')
 
   constructor(rootLocator: Locator, componentName?: string, componentType?: string) {
     super(rootLocator, componentName, componentType || 'changes cell')

src/test-data/shared/messages.ts

@@ -2,7 +2,7 @@ export const TOOLTIP_SEVERITY_MSG = {
   breaking: 'Breaking change is a change that breaks backward compatibility with the previous version of API. For example, deleting an operation, adding a required parameter or changing type of a parameter are breaking changes.',
   nonBreaking: 'Non-breaking change is change that does not break backward compatibility with the previous version of API. For example, adding new operation or optional parameter is non-breaking change.',
   semiBreaking: [
-    'Risky change is a change that breaks backward compatibility according to the rules:',
+    'A change requiring attention is a change that breaks backward compatibility according to the rules:',
     'operation was annotated as deprecated in at least two previous consecutive releases and then it was deleted',
     'operation is marked as no-BWC',
   ],

src/tests/portal/06-api-changes/6.1-api-changes-package.spec.ts

@@ -373,7 +373,7 @@ test.describe('6.1 API Changes (Package)', () => {
       await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.annotation!.description).changeSeverityIndicator).toHaveText('annotation')
       await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.unclassified!.description).changeSeverityIndicator).toHaveText('unclassified')
       await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.deprecated!.description).changeSeverityIndicator).toHaveText('deprecated')
-      await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.semiBreaking!.description).changeSeverityIndicator).toHaveText('risky')
+      await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.semiBreaking!.description).changeSeverityIndicator).toHaveText('requires attention')
       await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.nonBreaking!.description).changeSeverityIndicator).toHaveText('non-breaking')
       await expect.soft(apiChangesTab.table.getChangeDescriptionCell(CREATE_LIST_OF_USERS_V1_UPDATED.changes!.breaking!.description).changeSeverityIndicator).toHaveText('breaking')
 
@@ -383,7 +383,7 @@ test.describe('6.1 API Changes (Package)', () => {
 
       await apiChangesTab.table.getOperationRow(DEL_ORDER_V1).expandBtn.click()
 
-      await expect.soft(apiChangesTab.table.getChangeDescriptionCell(DEL_ORDER_V1.changes!.semiBreaking!.description).changeSeverityIndicator).toHaveText('risky')
+      await expect.soft(apiChangesTab.table.getChangeDescriptionCell(DEL_ORDER_V1.changes!.semiBreaking!.description).changeSeverityIndicator).toHaveText('requires attention')
     })
 
   test('[P-CHPVW-5] Navigation to the Operation Compare page',

src/tests/portal/09-comparison/9.1-compare-package-versions.spec.ts

@@ -637,7 +637,7 @@ test.describe('09.1 Compare Package versions', () => {
       await expect.soft(updateUserRow.rightSummary.path).toHaveText(`${UPDATE_USER_V1.method}${UPDATE_USER_V1.path}`)
       await expect.soft(updateUserRow.rightSummary.changes.deprecated).toHaveText('1')
 
-      await expect.soft(delOrderRow.changeSeverityIndicator).toHaveText('risky')
+      await expect.soft(delOrderRow.changeSeverityIndicator).toHaveText('requires attention')
       await expect.soft(delOrderRow.leftSummary.title).toHaveText(DEL_ORDER_V1.title)
       await expect.soft(delOrderRow.leftSummary.path).toHaveText(`${DEL_ORDER_V1.method}${DEL_ORDER_V1.path}`)
       await expect.soft(delOrderRow.leftSummary.changes).not.toBeVisible()