Skip to content

Commit 3f67182

Browse files
authored
feat: playground improvements (#57)
* test: adapt playground tests to improvements from UI * test(playground): update element selectors for consistency - Replace `getByRole` selector with `getByTestId` for Send button - Update selector for server input in CustomServerSelect to use test ID
1 parent 5b7b4fd commit 3f67182

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

src/packages/portal/pages/PortalPage/OperationPage/PlaygroundPanel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { CustomServerSelect } from './PlaygroundPanel/CustomServerSelect'
66
export class PlaygroundPanel extends BaseComponent {
77

88
readonly serverSlt = new CustomServerSelect(this.page)
9-
readonly sendBtn = new Button(this.mainLocator.getByRole('button', { name: 'Send' }), 'Send')
9+
readonly sendBtn = new Button(this.mainLocator.getByTestId('SendButton'), 'Send')
1010
readonly tokenTxtFld = new TextField(this.mainLocator.locator('label:has-text("Token")+span+div'), 'Token')
1111
readonly textFilterTxtFld = new TextField(this.mainLocator.locator('label:has-text("textFilter")+span+div'), 'textFilter')
1212
readonly typesTxtFld = new TextField(this.mainLocator.locator('label:has-text("types")+span+div'), 'textFilter')

src/packages/portal/pages/PortalPage/OperationPage/PlaygroundPanel/AddCustomServerDialog.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export class AddCustomServerDialog extends BaseAddDialog {
77
readonly cloudAc = new Autocomplete(this.rootLocator.getByTestId('CloudAutocomplete'), 'Cloud')
88
readonly namespaceAc = new Autocomplete(this.rootLocator.getByTestId('NamespaceAutocomplete'), 'Namespace')
99
readonly serviceAc = new Autocomplete(this.rootLocator.getByTestId('ServiceAutocomplete'), 'Service')
10-
readonly urlTxtFld = new TextField(this.rootLocator.getByTestId('ServerUrlTextInput'), 'Server URL')
10+
readonly urlTxtFld = new TextField(this.rootLocator.getByTestId('ServerUrlTextField'), 'Server URL')
1111

1212
constructor(page: Page) {
1313
super(page)

src/packages/portal/pages/PortalPage/OperationPage/PlaygroundPanel/CustomServerSelect.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@ import { Button, Select } from '@shared/components/base'
22
import { type Page } from 'playwright/test'
33

44
export class CustomServerSelect extends Select {
5-
6-
readonly addCustomServerBtn = new Button(this.page.getByRole('option', { name: 'Add Custom Server' }), 'Add Custom Server')
5+
readonly addCustomServerBtn = new Button(this.page.getByTestId('AddCustomServerButton'), 'Add Custom Server')
76

87
constructor(page: Page) {
9-
super(page.getByTestId('PlaygroundPanel').locator('.MuiInputBase-root'), 'Custom Server')
8+
super(page.getByTestId('PlaygroundPanel').getByTestId('ServerSelect'), 'Custom Server')
109
}
1110
}

src/tests/portal/11-operations-details/11.1.1-details-rest-api-package.spec.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,9 @@ test.describe('11.1.1 Operations details REST API (Package)', () => {
246246

247247
await expect(operationPage.playgroundPanel.serverSlt.getListItem()).toHaveCount(4) //The "Add Custom Server" button is also a list item
248248
// Covering TestCase-B-1221
249-
await expect(operationPage.playgroundPanel.serverSlt.getListItem('Petstore server https://petstore.swagger.io/api/v1', { exact: false })).toBeVisible()
250-
await expect(operationPage.playgroundPanel.serverSlt.getListItem('Petstore server https://dev.petstore.swagger.io/api/v1', { exact: false })).toBeVisible()
251-
await expect(operationPage.playgroundPanel.serverSlt.getListItem('Petstore server https://test.petstore.swagger.io/api/v1', { exact: false })).toBeVisible()
249+
await expect(operationPage.playgroundPanel.serverSlt.getListItem('https://petstore.swagger.io/api/v1', { exact: false })).toBeVisible()
250+
await expect(operationPage.playgroundPanel.serverSlt.getListItem('https://dev.petstore.swagger.io/api/v1', { exact: false })).toBeVisible()
251+
await expect(operationPage.playgroundPanel.serverSlt.getListItem('https://test.petstore.swagger.io/api/v1', { exact: false })).toBeVisible()
252252
})
253253

254254
await test.step('Add Custom servers', async () => {
@@ -266,12 +266,12 @@ test.describe('11.1.1 Operations details REST API (Package)', () => {
266266

267267
await test.step('Add server 1', async () => {
268268
await operationPage.playgroundPanel.serverSlt.addCustomServerBtn.click() //WA: remove after fix previous step
269-
await operationPage.playgroundPanel.addServerDialog.cloudAc.clear()
269+
270270
await operationPage.playgroundPanel.addServerDialog.urlTxtFld.fill('https://api')
271271
await operationPage.playgroundPanel.addServerDialog.addBtn.click()
272272
await operationPage.playgroundPanel.serverSlt.click()
273273

274-
await expect(operationPage.playgroundPanel.serverSlt.getListItem('Custom Server 1', { exact: false })).toBeVisible()
274+
await expect(operationPage.playgroundPanel.serverSlt.getListItem('https://api', { exact: false })).toBeVisible()
275275
})
276276

277277
await test.step('Add server 2 and select it', async () => {
@@ -280,10 +280,10 @@ test.describe('11.1.1 Operations details REST API (Package)', () => {
280280
await operationPage.playgroundPanel.addServerDialog.addBtn.click()
281281
await operationPage.playgroundPanel.serverSlt.click()
282282

283-
await expect(operationPage.playgroundPanel.serverSlt.getListItem('Custom Server 1', { exact: false })).toBeVisible() //Cover TestCase-A-4737
284-
await expect(operationPage.playgroundPanel.serverSlt.getListItem('Custom Server 2', { exact: false })).toBeVisible()
283+
await expect(operationPage.playgroundPanel.serverSlt.getListItem('https://api', { exact: false })).toBeVisible() //Cover TestCase-A-4737
284+
await expect(operationPage.playgroundPanel.serverSlt.getListItem(getPlaygroundCustomServer(), { exact: false })).toBeVisible()
285285

286-
await operationPage.playgroundPanel.serverSlt.getListItem('Custom Server 2', { exact: false }).click()
286+
await operationPage.playgroundPanel.serverSlt.getListItem(getPlaygroundCustomServer(), { exact: false }).click()
287287
})
288288
})
289289

0 commit comments

Comments
 (0)