Skip to content

Commit b1558af

Browse files
authored
fix!: update info icon test IDs for consistency (#21)
Adaptation to the "Fix the display of Info icons in the UI" story. Updated the test IDs for info icons across multiple components to use 'InfoIcon' instead of 'InfoOutlinedIcon' and 'InfoButton' for consistency and clarity. BREAKING CHANGE: need corresponding changes in UI
1 parent 1fcd6c5 commit b1558af

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/packages/portal/pages/PortalPage/BaseVersionPage/ConfigureVersionTab.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export class ConfigureVersionTab extends Tab {
1515
readonly status = new Content(this.page.getByTestId('VersionStatusChip'), 'Version Status')
1616
readonly publishBtn = new Button(this.page.getByTestId('PublishButton'), 'Publish')
1717
readonly exitBtn = new Button(this.page.getByTestId('ExitButton'), 'Exit')
18-
readonly infoIcon = new Icon(this.page.getByTestId('CardHeader').getByTestId('InfoOutlinedIcon'), 'Title', 'info icon')
18+
readonly infoIcon = new Icon(this.page.getByTestId('CardHeader').getByTestId('InfoIcon'), 'Title', 'info icon')
1919
readonly searchbar = new SearchBar(this.page.getByTestId('SearchFile'), 'File')
2020
readonly browseFilesBtn = new Button(this.page.getByTestId('BrowseFilesButton'), 'Browse Files')
2121
readonly browseBtn = new Button(this.page.getByTestId('BrowseButton'), 'browse')

src/packages/portal/pages/PortalPage/BaseVersionPage/ConfigureVersionTab/ConfigureVersionFileRow.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export class ConfigureVersionFileRow extends TableRow {
55

66
readonly fileCell = new TableCell(this.mainLocator.getByTestId('Cell-file-column'), this.componentName, 'filename cell')
77
readonly labelsCell = new TableCell(this.mainLocator.getByTestId('Cell-labels-column'), this.componentName, 'labels cell')
8-
readonly infoIcon = new Icon(this.mainLocator.getByTestId('InfoOutlinedIcon'), this.componentName, 'info icon')
8+
readonly infoIcon = new Icon(this.mainLocator.getByTestId('InfoIcon'), this.componentName, 'info icon')
99
readonly restoreBtn = new Button(this.mainLocator.getByTestId('RestoreButton'), this.componentName, 'restore button')
1010
readonly fileBtn = new Button(this.mainLocator.getByTestId('FileTitleButton'), this.componentName)
1111
readonly removeBtn = new Button(this.mainLocator.getByTestId('RemoveButton'), this.componentName, 'remove button')

src/packages/portal/pages/PortalPage/VersionPage/VersionOverviewTab/OverviewRevisionsTab/OverviewRevisionRow.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export class OverviewRevisionRow extends TableRow {
1010
readonly publicationDateCell = new TableCell(this.rootLocator.getByTestId('Cell-publication-date'), `${this.componentName} Publication Date`)
1111
readonly publishedByCell = new TableCell(this.rootLocator.getByTestId('Cell-published-by'), `${this.componentName} Published By`)
1212
readonly link = new Link(this.rootLocator.getByRole('link'), `${this.componentName} Revision`)
13-
readonly infoIcon = new Icon(this.rootLocator.getByTestId('InfoButton'), `${this.componentName} Info`)
13+
readonly infoIcon = new Icon(this.rootLocator.getByTestId('InfoIcon'), `${this.componentName} Info`)
1414
readonly infoTooltip = new BaseComponent(this.rootLocator.page().getByRole('tooltip'), `${this.componentName} Info`, 'tooltip')
1515

1616
constructor(rootLocator: Locator, componentName?: string, componentType?: string) {

0 commit comments

Comments
 (0)