Skip to content

Commit 7baf988

Browse files
committed
fix: rename 'risky' changes to 'requires attention'
1 parent b6eb956 commit 7baf988

File tree

4 files changed

+15
-6
lines changed

4 files changed

+15
-6
lines changed

docs/Agent User Guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ To see the results go to Validation Results step. For each service for which a s
4242
">
4343
<div>
4444
<li>Breaking change is a change that breaks backward compatibility with the previous version of API. For example, deleting an operation, adding a required parameter or changing the type of a parameter are breaking changes.</li>
45-
<li>Risky change is a change that breaks backward compatibility according to the rules:</li>
45+
<li>A change requiring attention is a change that breaks backward compatibility according to the rules:</li>
4646
<ul>
4747
<li>operation or entity in the operation was annotated as deprecated in at least two previous consecutive releases and then it was deleted
4848
<li>operation is marked as no-BWC.</li>

docs/Portal User Guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ If during package version publication, you specified a previous release version,
697697

698698
- Breaking – Breaking change is a change that breaks backward compatibility with the previous version of API.
699699
For example, deleting an operation, adding a required parameter or changing the type of a parameter are breaking changes.
700-
- Risky – Risky change is a change that breaks backward compatibility according to the rules:
700+
- Requires Attention – A change requiring attention is a change that breaks backward compatibility according to the rules:
701701
- operation or entity in the operation was annotated as deprecated in at least two previous consecutive releases and then it was deleted
702702
- operation is marked as no-BWC
703703
- Deprecated – Deprecating change is a change that annotates an operation, parameter or schema as deprecated. Removing a "deprecated" annotation is also considered a deprecating change.

packages/shared/src/components/ChangesTooltip.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import type { ChangeSeverity } from '../entities/change-severities'
2020
import {
2121
CHANGE_SEVERITY_COLOR_MAP,
2222
CHANGE_SEVERITY_DESCRIPTION_MAP,
23-
CHANGE_SEVERITY_NAME_MAP,
23+
CHANGE_SEVERITY_TOOLTIP_TITLE_MAP,
2424
} from '../entities/change-severities'
2525
import { Box, Divider, Tooltip } from '@mui/material'
2626
import ListItem from '@mui/material/ListItem'
@@ -67,7 +67,7 @@ const ChangesTooltipContent: FC<ChangesTooltipContentProps> = memo<ChangesToolti
6767
category,
6868
}) => {
6969
const tooltipContent = CHANGE_SEVERITY_DESCRIPTION_MAP[changeType]
70-
const categoryTitle = `${category ? `${TOOLTIP_TITLE_BY_CATEGORY[category]} with ` : ''}${CHANGE_SEVERITY_NAME_MAP[changeType]} Changes`
70+
const categoryTitle = `${category ? `${TOOLTIP_TITLE_BY_CATEGORY[category]} with ` : ''}${CHANGE_SEVERITY_TOOLTIP_TITLE_MAP[changeType]}`
7171

7272
return (
7373
<Box sx={{ p: '4px 4px' }}>

packages/shared/src/entities/change-severities.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,26 @@ export const CHANGE_SEVERITY_COLOR_MAP: Record<ChangeSeverity, string> = {
5454

5555
export const CHANGE_SEVERITY_NAME_MAP: Record<ChangeSeverity, string> = {
5656
[BREAKING_CHANGE_SEVERITY]: 'Breaking',
57-
[SEMI_BREAKING_CHANGE_SEVERITY]: 'Risky',
57+
[SEMI_BREAKING_CHANGE_SEVERITY]: 'Requires Attention',
5858
[DEPRECATED_CHANGE_SEVERITY]: 'Deprecated',
5959
[NON_BREAKING_CHANGE_SEVERITY]: 'Non-breaking',
6060
[UNCLASSIFIED_CHANGE_SEVERITY]: 'Unclassified',
6161
[ANNOTATION_CHANGE_SEVERITY]: 'Annotation',
6262
}
6363

64+
export const CHANGE_SEVERITY_TOOLTIP_TITLE_MAP: Record<ChangeSeverity, string> = {
65+
[BREAKING_CHANGE_SEVERITY]: 'Breaking Changes',
66+
[SEMI_BREAKING_CHANGE_SEVERITY]: 'Changes Requiring Attention',
67+
[DEPRECATED_CHANGE_SEVERITY]: 'Deprecated Changes',
68+
[NON_BREAKING_CHANGE_SEVERITY]: 'Non-breaking Changes',
69+
[UNCLASSIFIED_CHANGE_SEVERITY]: 'Unclassified Changes',
70+
[ANNOTATION_CHANGE_SEVERITY]: 'Annotation Changes',
71+
}
72+
6473
export const CHANGE_SEVERITY_DESCRIPTION_MAP: Record<ChangeSeverity, { text: string; options?: string[] }> = {
6574
[BREAKING_CHANGE_SEVERITY]: { text: 'Breaking change is a change that breaks backward compatibility with the previous version of API. For example, deleting an operation, adding a required parameter or changing type of a parameter are breaking changes.' },
6675
[SEMI_BREAKING_CHANGE_SEVERITY]: {
67-
text: 'Risky change is a change that breaks backward compatibility according to the rules:',
76+
text: 'A change requiring attention is a change that breaks backward compatibility according to the rules:',
6877
options: ['operation was annotated as deprecated in at least two previous consecutive releases and then it was deleted', 'operation is marked as no-BWC'],
6978
},
7079
[DEPRECATED_CHANGE_SEVERITY]: { text: 'Deprecating change is a change that annotates an operation, parameter or schema as deprecated. Removing a "deprecated" annotation is also considered a deprecating change.' },

0 commit comments

Comments
 (0)