From 6f1eb859c5ba7aa094a0ca227777b0801ce4e3d1 Mon Sep 17 00:00:00 2001 From: Artem Badeinov <51969741+Gravelord@users.noreply.github.com> Date: Wed, 17 Sep 2025 23:50:41 +0300 Subject: [PATCH 1/7] fix: Improve hardcode images test --- .../robot/tests/image_tests/image_tests.robot | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot b/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot index dfa476e..bc9df5a 100644 --- a/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot +++ b/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot @@ -6,14 +6,27 @@ Library String Library Collections Library PlatformLibrary managed_by_operator=%{RABBIT_IS_MANAGED_BY_OPERATOR} +*** Keywords *** +Get Image Tag + [Arguments] ${image} + ${parts}= Split String ${image} : + ${length}= Get Length ${parts} + Run Keyword If ${length} > 1 Return From Keyword ${parts[2]} ELSE Fail Image has no tag: ${image} *** Test Cases *** Test Hardcoded Images - [Tags] all rabbitmq_images + [Tags] consul_images ${stripped_resources}= Strip String ${MONITORED_IMAGES} characters=, mode=right @{list_resources} = Split String ${stripped_resources} , FOR ${resource} IN @{list_resources} - ${type} ${name} ${container_name} ${image}= Split String ${resource} + ${type} ${name} ${container_name} ${image}= Split String ${resource} ${resource_image}= Get Resource Image ${type} ${name} %{NAMESPACE} ${container_name} - Should Be Equal ${resource_image} ${image} - END \ No newline at end of file + + ${expected_tag}= Get Image Tag ${image} + ${actual_tag}= Get Image Tag ${resource_image} + + Log To Console \n[COMPARE] ${resource}: Expected tag = ${expected_tag}, Actual tag = ${actual_tag} + + Run Keyword And Continue On Failure Should Be Equal ${actual_tag} ${expected_tag} + + END From 8372265b6a1d27d1fa3dbb4343ba47a084d3b9b0 Mon Sep 17 00:00:00 2001 From: Artem Badeinov <51969741+Gravelord@users.noreply.github.com> Date: Wed, 17 Sep 2025 23:51:59 +0300 Subject: [PATCH 2/7] fix: Improve hardcode images test --- .../robot/tests/image_tests/image_tests.robot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot b/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot index bc9df5a..259db83 100644 --- a/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot +++ b/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot @@ -15,7 +15,7 @@ Get Image Tag *** Test Cases *** Test Hardcoded Images - [Tags] consul_images + [Tags] all rabbitmq_images ${stripped_resources}= Strip String ${MONITORED_IMAGES} characters=, mode=right @{list_resources} = Split String ${stripped_resources} , FOR ${resource} IN @{list_resources} From 062cb5c5ce6888cfe46916f22c11f0f5b9480f7a Mon Sep 17 00:00:00 2001 From: Artem Badeinov <51969741+Gravelord@users.noreply.github.com> Date: Thu, 18 Sep 2025 02:05:50 +0300 Subject: [PATCH 3/7] fix: Improve hardcode images test From bc627655b544acdce59da2d4c9dff1e31a93c738 Mon Sep 17 00:00:00 2001 From: Artem Badeinov <51969741+Gravelord@users.noreply.github.com> Date: Thu, 18 Sep 2025 02:15:31 +0300 Subject: [PATCH 4/7] fix: Improve hardcode images test From 0bce2faf00b5b600404dfbd27601c0e13522c1ef Mon Sep 17 00:00:00 2001 From: Artem Badeinov <51969741+Gravelord@users.noreply.github.com> Date: Thu, 18 Sep 2025 02:15:43 +0300 Subject: [PATCH 5/7] fix: Improve hardcode images test --- .../robot/tests/image_tests/image_tests.robot | 1 + 1 file changed, 1 insertion(+) diff --git a/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot b/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot index 259db83..a632a6a 100644 --- a/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot +++ b/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot @@ -30,3 +30,4 @@ Test Hardcoded Images Run Keyword And Continue On Failure Should Be Equal ${actual_tag} ${expected_tag} END + From 8c1c640ede2ae25e24a1db66c9451a62514ea95f Mon Sep 17 00:00:00 2001 From: Artem Badeinov <51969741+Gravelord@users.noreply.github.com> Date: Thu, 16 Oct 2025 14:52:35 +0300 Subject: [PATCH 6/7] fix: Improve hardcode images test --- .../robot/tests/image_tests/image_tests.robot | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot b/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot index a632a6a..962470d 100644 --- a/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot +++ b/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot @@ -11,7 +11,9 @@ Get Image Tag [Arguments] ${image} ${parts}= Split String ${image} : ${length}= Get Length ${parts} - Run Keyword If ${length} > 1 Return From Keyword ${parts[2]} ELSE Fail Image has no tag: ${image} + Run Keywords + ... Log To Console \n[ERROR] Image ${parts} has no tag: ${image}\nMonitored images list: ${MONITORED_IMAGES} + ... AND Fail Some images were not found, please check your .helpers template and description.yaml in the repository *** Test Cases *** Test Hardcoded Images From a9cca1bd1e21a85ae0e7d5d81310c4a7a14c3613 Mon Sep 17 00:00:00 2001 From: Artem Badeinov <51969741+Gravelord@users.noreply.github.com> Date: Thu, 16 Oct 2025 15:16:54 +0300 Subject: [PATCH 7/7] fix: Improve hardcode images test --- .../robot/tests/image_tests/image_tests.robot | 1 + 1 file changed, 1 insertion(+) diff --git a/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot b/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot index 962470d..db6694d 100644 --- a/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot +++ b/operator/operator-robot-image/robot/tests/image_tests/image_tests.robot @@ -11,6 +11,7 @@ Get Image Tag [Arguments] ${image} ${parts}= Split String ${image} : ${length}= Get Length ${parts} + Run Keyword If ${length} > 1 Return From Keyword ${parts[2]} Run Keywords ... Log To Console \n[ERROR] Image ${parts} has no tag: ${image}\nMonitored images list: ${MONITORED_IMAGES} ... AND Fail Some images were not found, please check your .helpers template and description.yaml in the repository