Skip to content

Commit ff3de28

Browse files
authored
Merge pull request #267 from Netcracker/feature/update_npm_publish
feat: Updated the npm_publish
2 parents ca15f81 + 93f9287 commit ff3de28

File tree

2 files changed

+11
-16
lines changed

2 files changed

+11
-16
lines changed
Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,6 @@ jobs:
110110
- name: Run tests
111111
run: npm test --if-present
112112

113-
- name: Commit and Push changes
114-
uses: ./.github/actions/commit-and-push
115-
with:
116-
branch_name: ${{ inputs.branch_name }}
117-
118113
- name: Publish Package
119114
run: |
120115
npm config get registry

README.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,14 @@ There are several reusable workflows which should be added into every Netcracker
6666

6767
### Mandatory workflows list
6868

69-
- CLA: https://github.com/Netcracker/.github/blob/main/workflow-templates/cla.yaml
70-
- Automatic PR Labeler: https://github.com/Netcracker/.github/blob/main/workflow-templates/automatic-pr-labeler.yaml
71-
- Link Checker: https://github.com/Netcracker/.github/blob/main/workflow-templates/link-checker.yaml
72-
- Assign PR: https://github.com/Netcracker/.github/blob/main/workflow-templates/pr-assigner.yml
73-
- Lint Code Base: https://github.com/Netcracker/.github/blob/main/workflow-templates/super-linter.yaml
74-
- Profanity filter: https://github.com/Netcracker/.github/blob/main/workflow-templates/profanity-filter.yaml
75-
- Lint PR Title: https://github.com/Netcracker/.github/blob/main/workflow-templates/pr-lint-title.yaml
76-
- Conventional Commits PR Check: https://github.com/Netcracker/.github/blob/main/workflow-templates/pr-conventional-commits.yaml
69+
- CLA: [workflow template](https://github.com/Netcracker/.github/blob/main/workflow-templates/cla.yaml)
70+
- Automatic PR Labeler: [workflow template](https://github.com/Netcracker/.github/blob/main/workflow-templates/automatic-pr-labeler.yaml)
71+
- Link Checker: [workflow template](https://github.com/Netcracker/.github/blob/main/workflow-templates/link-checker.yaml)
72+
- Assign PR: [workflow template](https://github.com/Netcracker/.github/blob/main/workflow-templates/pr-assigner.yml)
73+
- Lint codebase: [workflow template](https://github.com/Netcracker/.github/blob/main/workflow-templates/super-linter.yaml)
74+
- Profanity filter: [workflow template](https://github.com/Netcracker/.github/blob/main/workflow-templates/profanity-filter.yaml)
75+
- Lint PR Title: [workflow template](https://github.com/Netcracker/.github/blob/main/workflow-templates/pr-lint-title.yaml)
76+
- Conventional Commits PR Check: [workflow template](https://github.com/Netcracker/.github/blob/main/workflow-templates/pr-conventional-commits.yaml)
7777

7878
### CLA
7979

@@ -151,7 +151,7 @@ To add the workflow into your repository copy the [prepared file](https://github
151151

152152
### Lint PR Title
153153

154-
The workflow will check pull request title if it follows [Conventional Commits](conventionalcommits.org) strategy.
154+
The workflow will check pull request title if it follows [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) strategy.
155155

156156
More info on underlying GitHub Action can be found here [Semantic Pull Request](https://github.com/amannn/action-semantic-pull-request).
157157

@@ -163,7 +163,7 @@ To add the workflow into your repository copy the [prepared file](https://github
163163

164164
## Maven project release workflow
165165

166-
Maven project release workflow is used to make a GitHub release and publish released artifacts into Maven Central or Github packages.
166+
Maven project release workflow is used to make a GitHub release and publish released artifacts into Maven Central or GitHub packages.
167167
The workflow consists of several sequential jobs:
168168

169169
1. Checks if the tag already exists.
@@ -239,7 +239,7 @@ The workflow consists of several sequential jobs:
239239
1. Checks if the tag already exists.
240240
2. Ceates a new tag with name "v${version}.
241241
3. [Builds and publishes a Docker image](./docs/reusable/docker-publish.md).
242-
4. [Create GitHub release](./docs/reusable/create-github-release.md)
242+
4. Create GitHub release <!-- TODO: Will be added -->
243243

244244
---
245245

0 commit comments

Comments
 (0)