Skip to content

Commit b62e95d

Browse files
committed
Polish gh-910
* expand conditional for generating required-args constructor to check requiredFields.size < 256 even if fields is not
1 parent 1bc91ba commit b62e95d

File tree

1 file changed

+6
-5
lines changed
  • graphql-dgs-codegen-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/java

1 file changed

+6
-5
lines changed

graphql-dgs-codegen-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/generators/java/DataTypeGenerator.kt

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -462,13 +462,14 @@ abstract class BaseDataTypeGenerator(
462462
val requiredFields = fields.filter { !it.nullable }
463463

464464
if (config.generateJSpecifyAnnotations) {
465-
val allFieldsNullable = requiredFields.isEmpty()
466-
addDefaultConstructor(javaType, allFieldsNullable)
465+
addDefaultConstructor(javaType, requiredFields.isEmpty())
467466

468-
if (config.javaGenerateAllConstructor && fields.isNotEmpty() && fields.size < 256) {
469-
addParameterizedConstructor(fields, javaType)
467+
if (config.javaGenerateAllConstructor) {
468+
if (fields.isNotEmpty() && fields.size < 256) {
469+
addParameterizedConstructor(fields, javaType)
470+
}
470471

471-
if (requiredFields.isNotEmpty() && requiredFields.size < fields.size) {
472+
if (requiredFields.isNotEmpty() && requiredFields.size < fields.size && requiredFields.size < 256) {
472473
addParameterizedConstructor(requiredFields, javaType)
473474
}
474475
}

0 commit comments

Comments
 (0)