Merge pull request #176 from Netflix/fix/test

iparadiso · web-flow · commit 5379ac307c9e · 2025-05-29T13:51:04.000-07:00
handle nullability due to breaking changes in DataLoader v4.0.0
diff --git a/src/main/kotlin/com/example/demo/datafetchers/ReviewsDataFetcher.kt b/src/main/kotlin/com/example/demo/datafetchers/ReviewsDataFetcher.kt
@@ -46,7 +46,7 @@ class ReviewsDataFetcher(private val reviewsService: ReviewsService) {
         val show : Show? = dfe.getSource()
 
         //Load the reviews from the DataLoader. This call is async and will be batched by the DataLoader mechanism.
-        return reviewsDataLoader.load(show?.id)
+        return show?.id?.let { reviewsDataLoader.load(it) } ?: CompletableFuture.completedFuture(emptyList())
     }
 
     @DgsMutation

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class ReviewsDataFetcher(private val reviewsService: ReviewsService) {`
`46`	`46`	`val show : Show? = dfe.getSource()`
`47`	`47`
`48`	`48`	`//Load the reviews from the DataLoader. This call is async and will be batched by the DataLoader mechanism.`
`49`		`- return reviewsDataLoader.load(show?.id)`
	`49`	`+ return show?.id?.let { reviewsDataLoader.load(it) } ?: CompletableFuture.completedFuture(emptyList())`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`@DgsMutation`