fix: minor CUDA related memory leaks

Author: Max Blaeser

libvmaf/src/cuda/picture_cuda.c

@@ -216,7 +216,7 @@ int vmaf_cuda_picture_free(VmafPicture *pic, void *cookie)
     if (!pic) return -EINVAL;
 
     int err = vmaf_ref_load(pic->ref);
-    if (!err) -EINVAL;
+    if (!err) return -EINVAL;
 
     VmafPicturePrivate *priv = pic->priv;
     VmafCudaCookie *cuda_cookie = cookie;
@@ -232,6 +232,7 @@ int vmaf_cuda_picture_free(VmafPicture *pic, void *cookie)
     CHECK_CUDA(cuEventDestroy(priv->cuda.ready));
     CHECK_CUDA(cuStreamDestroy(priv->cuda.str));
     CHECK_CUDA(cuCtxPopCurrent(NULL));
+    vmaf_ref_close(pic->ref);
     free(priv);
     memset(pic, 0, sizeof(*pic));
 

libvmaf/src/cuda/ring_buffer.c

@@ -85,6 +85,7 @@ int vmaf_ring_buffer_close(VmafRingBuffer *ring_buffer)
     }
 
     free(ring_buffer->pic);
+    free(ring_buffer);
     return err;
 }
 

libvmaf/src/feature/cuda/integer_adm_cuda.c

@@ -1123,6 +1123,10 @@ static int init_fex_cuda(VmafFeatureExtractor *fex, enum VmafPixelFormat pix_fmt
         ret |= vmaf_cuda_buffer_free(fex->cu_state, s->buf.tmp_ref);
         free(s->buf.tmp_ref);
     }
+    if (s->buf.tmp_dis) {
+        ret |= vmaf_cuda_buffer_free(fex->cu_state, s->buf.tmp_dis);
+        free(s->buf.tmp_dis);
+    }
     if (s->buf.tmp_accum) {
         ret |= vmaf_cuda_buffer_free(fex->cu_state, s->buf.tmp_accum);
         free(s->buf.tmp_accum);
@@ -1197,6 +1201,10 @@ static int close_fex_cuda(VmafFeatureExtractor *fex)
         ret |= vmaf_cuda_buffer_free(fex->cu_state, s->buf.tmp_ref);
         free(s->buf.tmp_ref);
     }
+    if (s->buf.tmp_dis) {
+        ret |= vmaf_cuda_buffer_free(fex->cu_state, s->buf.tmp_dis);
+        free(s->buf.tmp_dis);
+    }
     if (s->buf.tmp_accum) {
         ret |= vmaf_cuda_buffer_free(fex->cu_state, s->buf.tmp_accum);
         free(s->buf.tmp_accum);

libvmaf/src/feature/cuda/integer_vif_cuda.c

@@ -203,6 +203,9 @@ static int init_fex_cuda(VmafFeatureExtractor *fex, enum VmafPixelFormat pix_fmt
     if (s->buf.accum_host) {
         ret |= vmaf_cuda_buffer_host_free(fex->cu_state, s->buf.accum_host);
     }
+    if (s->buf.cpu_param_buf) {
+        free(s->buf.cpu_param_buf);
+    }
 
     return -ENOMEM;
 }
@@ -517,6 +520,9 @@ static int close_fex_cuda(VmafFeatureExtractor *fex)
     if (s->buf.accum_host) {
         ret |= vmaf_cuda_buffer_host_free(fex->cu_state, s->buf.accum_host);
     }
+    if (s->buf.cpu_param_buf) {
+        free(s->buf.cpu_param_buf);
+    }
     ret |= vmaf_dictionary_free(&s->feature_name_dict);
     return ret;
 }