NethVoice: voicemail smarthost takes default freepbx "From:" leading to email being refused

[Stell0]

When smarthost for sending voicemails is configured, the "From:" field is setted to "asterisk@hostname" this usually leads to email being refused

Steps to reproduce

• configure smarthost
• configure voicemail
• send a voicemail using smarthost
• check the "From:" field (or the journal log if the email is refused)

Expected behavior

• "From:" should be environment SMTP_FROM_ADDRESS if configured
• "From:" should be taken from send_email command line parameter -f
• if SMTP_FROM_ADDRESS isn't configured, it should be BRAND_NAME@from_domain where
  • from domain is the domain of username if it contains a @
  • from domain should be the NETHVOICE_HOST if it is a valid host
  • from domain should be the smarthost domain

Actual behavior

• SMTP_FROM_ADDRESS is ignored
• default "From:" is used

See also

https://mattermost.nethesis.it/nethesis/pl/w658zsa6utduuje3mah1etmzca

[Stell0]

Test case:

• configure voicemail
• check that email is sent to "NethVoice foo@example.com, where foo is the username of smarthost, example.com is the domain in the username (if username has "@" in it) or SMTP_HOST domain (if username doesn't have "@" in it)
• set the environment variable SMTP_FROM_ADDRESS in environment file, restart freepbx
  • check that "Foo Bar foo@example.com" format send email to "Foo Bar foo@example.com"
  • check that "foo@example.com" format send email to "NethVoice foo@example.com"
• in Freepbx > Settings > Voicemail Admin > Email add -f bar@example.com and check that voicemail is sent to bar@example.com

[Stell0]

1.5.4-testing.3