Export users CSV data fails after AD migration

[DavidePrincipi]

After migrating Samba AD to NS8, the Export data action fails with Python KeyError: 'DOMAIN' error.

Steps to reproduce

• Migrate NS7 NSDC to NS8
• Export users and groups in CSV format

Expected behavior

A CSV file is downloaded

Actual behavior

A task error occurs. The error message is

Traceback (most recent call last):
  File "/home/samba1/.config/actions/export-users/50export_users", line 13, in <module>
    "records": samba.export_users(),
               ^^^^^^^^^^^^^^^^^^^^
  File "/home/samba1/.config/pypkg/samba.py", line 313, in export_users
    adb = _get_accounts()
          ^^^^^^^^^^^^^^^
  File "/home/samba1/.config/pypkg/samba.py", line 625, in _get_accounts
    '-b', get_ad_ldap_suffix(),
          ^^^^^^^^^^^^^^^^^^^^
  File "/home/samba1/.config/pypkg/samba.py", line 294, in get_ad_ldap_suffix
    parts = os.environ["DOMAIN"].split(".")
            ~~~~~~~~~~^^^^^^^^^^
  File "<frozen os>", line 679, in __getitem__
KeyError: 'DOMAIN'

Components

• Core 3.16.0
• Samba 3.6.0

See also

Discussion https://mattermost.nethesis.it/nethesis/pl/pebni7wdw38w8fwaxg9b7hif8c

---

Thanks to @nrauso

[DavidePrincipi]

In Testing Samba 3.4.1-dev.1

Test case

• Override stable samba with Testing version, or enable Testing for default apps repository.

• Migrate AD from NS7.

• Check the bug is not reproducible with the Testing version.

• Check that DOMAIN is set in the environment:

  runagent -m samba1 grep ^DOMAIN environment
  

[nrauso]

test case: VERIFIED

The export works as expected, and the ENV variable exists:

~]# runagent -m samba1 grep ^DOMAIN environment
DOMAIN=ad.mytest.org