Skip to content

Commit 6f22795

Browse files
authored
fix(flashstart): reloading firewall instead of restarting (#1432)
1 parent 3437747 commit 6f22795

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

packages/ns-flashstart/files/ns-flashstart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,8 @@ def __save(pending_changes: bool):
137137
if pending_dhcp:
138138
subprocess.run(['ubus', 'call', 'uci', 'commit', json.dumps({'config': 'dhcp'})], check=True)
139139
if pending_firewall:
140-
# reload the firewall if changes are there, this is done cause sets are not reloaded correctly after the
141-
# commit this 100% needs to be fixed upstream.
142-
e_uci.commit('firewall')
143-
subprocess.run(['fw4', 'restart'], capture_output=True)
140+
subprocess.run(['ubus', 'call', 'uci', 'commit', json.dumps({'config': 'firewall'})], check=True)
141+
subprocess.run(['fw4', 'reload-sets'], capture_output=True)
144142

145143

146144
def __add_bypass_ipset():

0 commit comments

Comments
 (0)