mwan3 restart is slow

[filippocarletti]

/etc/init.d/mwan3 restart could take a long time because of mwan3.user scripts.
Currently, the only script running is the my.nethesis wan up/down alert.

Steps to reproduce

• Use a system with a subscription to my.nethesis.it
• Block https access to my.nethesis.it (see below)
• Run time /etc/init.d/mwan3 restart

Expected behavior

mwan3 restart should complete in a few seconds (2.4 on my system)

Actual behavior

Restart takes 9 minutes.

root@NethSec:~# time /etc/init.d/mwan3 restart
/usr/libexec/ns-plug/mwan-hooks: line 17: failed_count++: not found

real	9m0.367s
user	0m0.326s
sys	0m0.103s

Block rule for my.nethesis

config rule 'ns_63ec884b'
	option name 'block-my'
	option dest 'wan'
	list dest_ip '188.166.58.97'
	option target 'DROP'
	option ns_service 'https'
	list proto 'tcp'
	list proto 'udp'
	option dest_port '443'
	option enabled '1'
	option log '0'

See also

https://openwrt.org/docs/guide-user/network/wan/multiwan/mwan3#alertsnotifications

[filippocarletti]

Error "/usr/libexec/ns-plug/mwan-hooks: line 17: failed_count++: not found" is dealt in PR #993

[Tbaile]

QA: check that the issue is not reproducible

Image: 23.05.5-ns.1.4.1-42-g66ecef537

[gsanchietti]

Issue verified: the restart does not block even if remote alert server is not reachable.