PUBLIC_ENDPOINTS variable not updated on module upgrade

[Tbaile]

Steps to reproduce

• Install the NethSecurity Controller version < v2.0.0
• Upgrade the module to a new version without a fresh install.
• Observe the environment variables after upgrading the module by accessing via SSH to the module and running grep PUBLIC_ENDPOINTS network.env

Expected behavior

After upgrading the controller module, the PUBLIC_ENDPOINTS variable should be properly set/updated as it is during a fresh install.

Actual behavior

The PUBLIC_ENDPOINTS variable is configured only on initial installation. On upgrade, it is not added by upgrade scripts, resulting in values missing and units not be able to connect to the controller.

Components

NethSecurity Controller Module <= 1.4.4

See also

• Helpdesk ticket: https://helpdesk.nethesis.it/a/tickets/196713
• Mattermost discussion: https://mattermost.nethesis.it/nethesis/pl/jjqn86i38fdzfck98azqqdr3be
• GitHub reference: https://github.com/NethServer/ns8-nethsecurity-controller/blob/9b98c1cbb2a037b7974f1bab11a3659e79bb9a77/imageroot/actions/create-module/20initialize#L44

[Tbaile]

QA:
Install a version before the V2 with: add-module ghcr.io/nethserver/nethsecurity-controller:1.2.8, check with the grep provided above that there's no PUBLIC_ENDPOINTS set
Update the module with the following version: ghcr.io/nethserver/nethsecurity-controller:2.1.4-dev.1
Check that the issue is solved

[francio87]

After update to 2.1.4-dev.2 :

[nethsecurity-controller2@rl1 state]$ grep PUBLIC_ENDPOINTS network.env
PUBLIC_ENDPOINTS=/api/units/register