Skip to content

Commit ae1b31d

Browse files
Copilotstephdl
andauthored
[WIP] Update samba provider setup for additional volumes based on feedback (#1066)
* Initial plan * fix(AddInternalProviderModal): add sambaModule check before accessing sambaVolumes Co-authored-by: stephdl <3164851+stephdl@users.noreply.github.com> * refactor(AddInternalProviderModal): combine sambaModule checks for consistency Co-authored-by: stephdl <3164851+stephdl@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stephdl <3164851+stephdl@users.noreply.github.com>
1 parent 6960b8d commit ae1b31d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

core/ui/src/components/domains/AddInternalProviderModal.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -414,8 +414,8 @@ export default {
414414
if (!this.isSamba) {
415415
return nodeIds;
416416
}
417-
// If app doesn't require volumes, no nodes have additional storage for it
418-
if (this.sambaVolumes.length === 0) {
417+
// If Samba module is not loaded or app doesn't require volumes, no nodes have additional storage for it
418+
if (!this.sambaModule || this.sambaVolumes.length === 0) {
419419
return nodeIds;
420420
}
421421
if (this.nodesList && Array.isArray(this.nodesList)) {

0 commit comments

Comments
 (0)