fix: improve action tasks management

Use a cache instead of making unnecessary multiple API requests for
retrieving the context of a running task

Author: andre8244

core/ui/src/mixins/notification.js

@@ -1,4 +1,4 @@
-import { mapState, mapActions, mapGetters } from "vuex";
+import { mapState, mapActions, mapGetters, mapMutations } from "vuex";
 import to from "await-to-js";
 import {
   UtilService,
@@ -22,7 +22,9 @@ export default {
       "setNotificationDrawerShownInStore",
       "deleteNotificationInStore",
       "setPollingTimerForTaskInStore",
+      "getTaskContextFromCache",
     ]),
+    ...mapMutations(["setTaskContextInCache", "refreshTaskContextInCache"]),
     createNotification(notification) {
       // fill missing attributes
       if (!notification.type) {
@@ -185,27 +187,40 @@ export default {
       return `${taskContext.action}-${result}${eventId}`;
     },
     async handleProgressTaskMessage(taskPath, taskId, payload) {
-      const [err, contextResponse] = await to(this.getTaskContext(taskPath));
+      let taskContext = await this.getTaskContextFromCache(taskId);
 
-      if (err) {
-        console.error("error retrieving task info", err);
-        return;
-      }
+      console.log("@@ handleProgressTaskMessage", taskId); ////
+      console.log("@@ taskContext from cache", taskContext); ////
 
-      const taskStatus = payload.status;
+      if (!taskContext) {
+        console.log("@@ miss, calling context api..."); ////
 
-      if (!contextResponse.data.data) {
-        console.warn(
-          "task context not found, skipping",
-          taskId,
-          taskPath,
-          payload
-        );
-        return;
+        // fetch task context from API and store it in cache
+        const [err, contextResponse] = await to(this.getTaskContext(taskPath));
+
+        if (err) {
+          console.error("error retrieving task info", err);
+          return;
+        }
+
+        if (!contextResponse.data.data) {
+          console.warn(
+            "task context not found, skipping",
+            taskId,
+            taskPath,
+            payload
+          );
+          return;
+        }
+        taskContext = contextResponse.data.data.context;
+        this.setTaskContextInCache({ taskId, taskContext }); ////
+
+        console.log("@@ taskContext from api", taskContext); ////
       }
+      console.log("@@ taskContext!", taskContext); ////
 
-      const taskContext = contextResponse.data.data.context;
       let taskResult;
+      const taskStatus = payload.status;
 
       if (["completed", "aborted", "validation-failed"].includes(taskStatus)) {
         // get output and error

core/ui/src/store/index.js

@@ -34,6 +34,8 @@ export default new Vuex.Store({
       description: "",
     },
     migratingApps: [],
+    taskContextCache: new Map(),
+    taskContextCacheSize: 50, //// 50?
   },
   getters: {
     unreadNotifications: (state, getters) => {
@@ -190,6 +192,37 @@ export default new Vuex.Store({
     setMigratingApps(state, migratingApps) {
       state.migratingApps = migratingApps;
     },
+    refreshTaskContextInCache(state, payload) {
+      console.log("@@ refreshTaskContextInCache", payload); ////
+
+      const taskId = payload.taskId;
+      const taskContext = payload.taskContext;
+
+      // Refresh the item: delete and re-insert so it's "newest"
+      state.taskContextCache.delete(taskId);
+      state.taskContextCache.set(taskId, taskContext);
+    },
+    setTaskContextInCache(state, payload) {
+      console.log("@@ setTaskContextInCache", payload); ////
+
+      const taskId = payload.taskId;
+      const taskContext = payload.taskContext;
+
+      // If it already exists, delete it first to update the position
+      if (state.taskContextCache.has(taskId)) {
+        state.taskContextCache.delete(taskId);
+      }
+
+      // Remove the oldest entry if limit is reached
+      // .keys().next().value returns the first (oldest) key
+      if (state.taskContextCache.size >= state.taskContextCacheSize) {
+        const oldestKey = state.taskContextCache.keys().next().value;
+        state.taskContextCache.delete(oldestKey);
+
+        console.log("@@ deleted old key", oldestKey); ////
+      }
+      state.taskContextCache.set(taskId, taskContext);
+    },
   },
   actions: {
     setPollingTimerForTaskInStore(context, obj) {
@@ -282,6 +315,23 @@ export default new Vuex.Store({
     setMigratingAppsInStore(context, migratingApps) {
       context.commit("setMigratingApps", migratingApps);
     },
+    getTaskContextFromCache: (context, taskId) => {
+      console.log("@@ getTaskContextFromCache", taskId); ////
+
+      if (!context.state.taskContextCache.has(taskId)) {
+        console.log("@@ cache MISS", taskId); ////
+
+        // The requested task ID is not in the cache
+        return null;
+      }
+      const taskContext = context.state.taskContextCache.get(taskId);
+
+      console.log("@@ cache HIT", taskId, taskContext); ////
+
+      // Refresh the item: delete and re-insert so it's "newest"
+      context.commit("refreshTaskContextInCache", { taskId, taskContext });
+      return taskContext;
+    },
   },
 });