Skip to content

Commit f758dd0

Browse files
committed
refactor(AddInternalProviderModal, CreateDomainModal): optimize handling of additional volumes in listMountPointsCompleted
1 parent adfee16 commit f758dd0

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

core/ui/src/components/domains/AddInternalProviderModal.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -775,14 +775,15 @@ export default {
775775
this.loading.listMountPoints = false;
776776
},
777777
listMountPointsCompleted(taskContext, taskResult) {
778-
this.additionalVolumes = taskResult.output.mountpoints;
778+
const additionalVolumes = taskResult.output.mountpoints;
779779
// Add default disk at the end, push default property
780780
if (taskResult.output.default_disk) {
781-
this.additionalVolumes.push({
781+
additionalVolumes.push({
782782
...taskResult.output.default_disk,
783783
default: true, // mark as default disk
784784
});
785785
}
786+
this.additionalVolumes = additionalVolumes;
786787
this.loading.listMountPoints = false;
787788
},
788789
async installProvider(volumes) {

core/ui/src/components/domains/CreateDomainModal.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,14 +1025,15 @@ export default {
10251025
this.loading.listMountPoints = false;
10261026
},
10271027
listMountPointsCompleted(taskContext, taskResult) {
1028-
this.additionalVolumes = taskResult.output.mountpoints;
1028+
const additionalVolumes = taskResult.output.mountpoints;
10291029
// Add default disk at the end, push default property
10301030
if (taskResult.output.default_disk) {
1031-
this.additionalVolumes.push({
1031+
additionalVolumes.push({
10321032
...taskResult.output.default_disk,
10331033
default: true, // mark as default disk
10341034
});
10351035
}
1036+
this.additionalVolumes = additionalVolumes;
10361037
this.loading.listMountPoints = false;
10371038
},
10381039

0 commit comments

Comments
 (0)