fix: relax local part validator (#189)

Builtin group "Domain Admins" name contains a space. Relax the general
address local part validator and require strict validation only in the
add-address action.

Refs NethServer/dev#7533

Author: DavidePrincipi

imageroot/actions/add-address/validate-input.json

@@ -18,7 +18,7 @@
     ],
     "allOf": [
         {
-            "$ref": "http://schema.nethserver.org/mail.json#/$defs/mail-address"
+            "$ref": "http://schema.nethserver.org/mail.json#/$defs/mail-address-strict"
         }
     ]
 }

imageroot/validator-definitions.json

@@ -310,7 +310,7 @@
                     "type": "string",
                     "title": "Address local part",
                     "minLength": 1,
-                    "pattern": "^[a-zA-Z0-9](?:[a-zA-Z0-9._-]*[a-zA-Z0-9])?$"
+                    "pattern": "^[^@]+$"
                 },
                 "atype": {
                     "type": "string",
@@ -335,6 +335,26 @@
                 }
             }
         },
+        "mail-address-strict": {
+            "description": "Strict validation of mail address local part",
+            "allOf": [
+                {
+                    "$ref": "#/$defs/mail-address-base"
+                },
+                {
+                    "properties": {
+                        "local": {
+                            "type": "string",
+                            "title": "Address local part",
+                            "description": "Strict validation of local part",
+                            "minLength": 1,
+                            "pattern": "^[a-zA-Z0-9](?:[a-zA-Z0-9._-]*[a-zA-Z0-9])?$"
+
+                        }
+                    }
+                }
+            ]
+        },
         "mail-address-change-request": {
             "title": "Mail address change request",
             "description": "An object describing how to modify an existing mail address object",
@@ -1080,4 +1100,4 @@
             ]
         }
     }
-}
+}

tests/40__api/20__addresses.robot

@@ -19,6 +19,10 @@ Check users and groups addresses are in the address list
 Add a user address alias
     Run task    module/${MID}/add-address    {"atype":"domain","local":"u1-alias","domain":"${test_domain}","destinations":[{"dtype":"user","name":"u1"}]}
 
+Add invalid address
+    Run task    module/${MID}/add-address    {"atype":"domain","local":"u1 alias","domain":"${test_domain}","destinations":[{"dtype":"user","name":"u1"}]}
+    ...    rc_expected=10
+
 Add a group address alias
     Run task    module/${MID}/add-address    {"atype":"domain","local":"g1-alias","domain":"${test_domain}","destinations":[{"dtype":"group","name":"g1"}]}