chore: test update scenario

- enable automerge
- test both install and update scenarios
- use vanilla robotframework for backend tests only

Author: DavidePrincipi

.github/workflows/test-module.yml

@@ -14,14 +14,41 @@ on:
 jobs:
   module:
     if: ${{ github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == '' }}
-    uses: NethServer/ns8-github-actions/.github/workflows/module-info.yml@main
+    uses: NethServer/ns8-github-actions/.github/workflows/module-info.yml@v1
+
+  chooser:
+    runs-on: ubuntu-latest
+    outputs:
+      node_a: ${{ steps.pick.outputs.node_a }}
+      node_b: ${{ steps.pick.outputs.node_b }}
+    steps:
+      - id: pick
+        run: |
+          if (( $GITHUB_RUN_NUMBER % 2 )); then
+            echo "node_a=rl1" >> "$GITHUB_OUTPUT"
+            echo "node_b=dn1" >> "$GITHUB_OUTPUT"
+          else
+            echo "node_a=dn1" >> "$GITHUB_OUTPUT"
+            echo "node_b=rl1" >> "$GITHUB_OUTPUT"
+          fi
+
   run_tests:
-    needs: module
-    uses: NethServer/ns8-github-actions/.github/workflows/test-on-digitalocean-infra.yml@main
+    needs: [module, chooser]
+    strategy:
+      fail-fast: false
+      matrix:
+        scenario: [install, update]
+    uses: NethServer/ns8-github-actions/.github/workflows/test-on-digitalocean-infra.yml@v1
     with:
-      coremodules: "ghcr.io/${{needs.module.outputs.owner}}/${{needs.module.outputs.name}}:${{needs.module.outputs.tag}}"
-      args: "ghcr.io/${{needs.module.outputs.owner}}/${{needs.module.outputs.name}}:${{needs.module.outputs.tag}}"
-      repo_ref: ${{needs.module.outputs.sha}}
+      coremodules: ${{ matrix.scenario == 'install' && format('ghcr.io/{0}/{1}:{2}', needs.module.outputs.owner, needs.module.outputs.name, needs.module.outputs.tag) || '' }}
+      leader_nodes: >-
+        ${{
+          matrix.scenario == 'install'
+          && needs.chooser.outputs.node_a
+          || needs.chooser.outputs.node_b
+        }}
+      args: ${{ format('ghcr.io/{0}/{1}:{2} -v SCENARIO:{3}', needs.module.outputs.owner, needs.module.outputs.name, needs.module.outputs.tag, matrix.scenario) }}
+      repo_ref: ${{ needs.module.outputs.sha }}
       debug_shell: ${{ github.event.inputs.debug_shell == 'true' || false }}
     secrets:
       do_token: ${{ secrets.do_token }}

renovate.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://docs.renovatebot.com/renovate-schema.json",
   "extends": [
-    "local>NethServer/.github:ns8"
+    "local>NethServer/.github:ns8-automerge"
   ]
 }

test-module.sh

@@ -5,13 +5,7 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 #
 
-#
-# Hint: access the test logs on HTTP port 8000 with this command:
-#
-#     python -mhttp.server -d tests/outputs/ 8000 &
-#
-
-set -e
+set -e -a
 
 SSH_KEYFILE=${SSH_KEYFILE:-$HOME/.ssh/id_rsa}
 
@@ -20,30 +14,31 @@ IMAGE_URL="${2:?missing IMAGE_URL argument}"
 shift 2
 
 ssh_key="$(< $SSH_KEYFILE)"
+venvroot=/usr/local/venv
 
-cleanup() {
-    set +e
-    podman cp rf-core-runner:/home/pwuser/outputs tests/
-    podman stop rf-core-runner
-    podman rm rf-core-runner
-}
-
-trap cleanup EXIT
 podman run -i \
-    --network=host \
-    --volume=.:/home/pwuser/ns8-module:z \
-    --volume=site-packages:/home/pwuser/.local/lib/python3.12/site-packages:z \
-    --name rf-core-runner ghcr.io/marketsquare/robotframework-browser/rfbrowser-stable:19.1.2 \
-    bash -l -s <<EOF
+    --volume=.:/srv/source:z \
+    --volume=rftest-cache:${venvroot}:z \
+    --replace --name=rftest \
+    --env=ssh_key \
+    --env=venvroot \
+    --env=LEADER_NODE \
+    --env=IMAGE_URL \
+    docker.io/python:3.11-alpine \
+    ash -l -s -- "${@}" <<'EOF'
 set -e
-echo "$ssh_key" > /home/pwuser/ns8-key
-pip install -q -r /home/pwuser/ns8-module/tests/pythonreq.txt
-mkdir ~/outputs
-cd /home/pwuser/ns8-module
-exec robot -v NODE_ADDR:${LEADER_NODE} \
+echo "$ssh_key" > /tmp/idssh
+if [ ! -x ${venvroot}/bin/robot ] ; then
+    python3 -mvenv ${venvroot} --upgrade
+    ${venvroot}/bin/pip3 install -q -r /srv/source/tests/pythonreq.txt
+fi
+cd /srv/source
+mkdir -vp tests/outputs/
+exec ${venvroot}/bin/robot \
+    -v NODE_ADDR:${LEADER_NODE} \
     -v IMAGE_URL:${IMAGE_URL} \
-    -v SSH_KEYFILE:/home/pwuser/ns8-key \
-    --name "$(basename $PWD)" \
+    -v SSH_KEYFILE:/tmp/idssh \
+    --name traefik \
     --skiponfailure unstable \
-    -d ~/outputs ${@} /home/pwuser/ns8-module/tests/
+    -d tests/outputs "${@}" tests/
 EOF

tests/__init__.robot

@@ -8,6 +8,9 @@ Suite Teardown    Tear down connection and test suite tools
 ${SSH_KEYFILE}    %{HOME}/.ssh/id_ecdsa
 ${NODE_ADDR}      127.0.0.1
 ${MID}            traefik1
+${JOURNAL_SINCE}  0
+${SCENARIO}       install
+${IMAGE_URL}      ghcr.io/nethserver/traefik:latest
 
 *** Keywords ***
 Connect to the node
@@ -21,6 +24,7 @@ Setup connection and test suite tools
     Connect to the node
     Save the journal begin timestamp
     Set Global Variable    ${MID}    ${MID}
+    Run scenario
 
 Tear down connection and test suite tools
     Collect the suite journal
@@ -30,6 +34,13 @@ Save the journal begin timestamp
     Set Global Variable    ${JOURNAL_SINCE}    ${tsnow}
 
 Collect the suite journal
-    Execute Command    printf "Test suite starts at %s\n" "$(date -d @${JOURNAL_SINCE})" >>journal-dump.log
+    Execute Command    printf "Test suite starts at %s\n" "$(date -d @${JOURNAL_SINCE})" >journal-dump.log
     Execute Command    journalctl >>journal-dump.log
     SSHLibrary.Get File    journal-dump.log    ${OUTPUT DIR}/journal-${SUITE NAME}.log
+
+Run scenario
+    Log  Scenario ${SCENARIO} with ${IMAGE_URL}  console=${True}
+    IF    r'${SCENARIO}' == 'update'
+        ${out}  ${rc} =  Execute Command  api-cli run update-module --data '{"force":true,"module_url":"${IMAGE_URL}","instances":["${MID}"]}'  return_rc=${True}
+        Should Be Equal As Integers  ${rc}  0  action update-module ${IMAGE_URL} failed
+    END