Remove deprecated environment script and improve variable access consistency (#163)

Refs NethServer/dev#7690

Author: stephdl

imageroot/actions/configure-module/05set_default_env

@@ -0,0 +1,29 @@
+#!/usr/bin/env python3
+
+#
+# Copyright (C) 2025 Nethesis S.r.l.
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+
+import os
+import agent
+
+defaults = {
+    'WEBTOP_TIMEZONE': '-',
+    'WEBTOP_LOCALE': 'en_US',
+    'WEBDAV_DEBUG': 'False',
+    'WEBDAV_LOG_LEVEL': 'ERROR',
+    'Z_PUSH_LOG_LEVEL': 'ERROR',
+    'Z_PUSH_IMAP_SERVER': '10.5.4.1',
+    'Z_PUSH_SMTP_SERVER': '10.5.4.1',
+    'Z_PUSH_SMTP_PORT': '25',
+    'Z_PUSH_USE_LEGACY_FOLDER_IDS': 'false',
+    'WEBAPP_JS_DEBUG': 'False',
+    'WEBAPP_MIN_MEMORY': '512',
+    'WEBAPP_MAX_MEMORY': '1024',
+    'EJABBERD_MODULE': '',
+}
+
+for key, value in defaults.items():
+    if key not in os.environ:
+        agent.set_env(key, value)

imageroot/actions/create-module/10env

@@ -13,23 +13,23 @@ import agent
 config={
         "hostname": os.getenv("WEBTOP_HOSTNAME", ""),
         "request_https_certificate": agent.get_route(os.environ['MODULE_ID']).get('lets_encrypt', False),
-        "locale": os.environ["WEBTOP_LOCALE"],
-        "timezone": os.environ["WEBTOP_TIMEZONE"],
+        "locale": os.getenv("WEBTOP_LOCALE", "en_US"),
+        "timezone": os.getenv("WEBTOP_TIMEZONE", "-"),
         "mail_module": os.getenv("MAIL_MODULE", ""),
         "mail_domain": os.getenv("MAIL_DOMAIN", ""),
         "ejabberd_module": os.getenv("EJABBERD_MODULE", ""),
         "ejabberd_domain": os.getenv("EJABBERD_DOMAIN", ""),
         "webapp": {
-            "debug": os.environ["WEBAPP_JS_DEBUG"].lower() in ('true', '1', 't'),
-            "min_memory": int(os.environ["WEBAPP_MIN_MEMORY"]),
-            "max_memory": int(os.environ["WEBAPP_MAX_MEMORY"]),
+            "debug": os.getenv("WEBAPP_JS_DEBUG", 'False').lower() in ('true', '1', 't'),
+            "min_memory": int(os.getenv("WEBAPP_MIN_MEMORY", "512")),
+            "max_memory": int(os.getenv("WEBAPP_MAX_MEMORY", "1024")),
             },
         "webdav": {
-            "debug": os.environ["WEBDAV_DEBUG"].lower() in ('true', '1', 't'),
-            "loglevel": os.environ["WEBDAV_LOG_LEVEL"],
+            "debug": os.getenv("WEBDAV_DEBUG", 'False').lower() in ('true', '1', 't'),
+            "loglevel": os.getenv("WEBDAV_LOG_LEVEL", "ERROR"),
             },
         "zpush": {
-            "loglevel": os.environ["Z_PUSH_LOG_LEVEL"],
+            "loglevel": os.getenv("Z_PUSH_LOG_LEVEL", "ERROR"),
             },
         "pecbridge_admin_mail": os.getenv("PECBRIDGE_ADMIN_MAIL", ""),
         "pecbridge_from_address": os.getenv("PECBRIDGE_FROM_ADDRESS", ""),