Skip to content

Fix async/await anti-patterns in ChannelStream #418

Fix async/await anti-patterns in ChannelStream

Fix async/await anti-patterns in ChannelStream #418

Re-run triggered December 7, 2025 15:53
Status Success
Total duration 1m 37s
Artifacts

test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

20 warnings
Test: src/libp2p/Libp2p.Protocols.Pubsub/PubsubRouter.cs#L223
Dereference of a possibly null reference.
Test: src/libp2p/Libp2p.Protocols.Noise/NoiseProtocol.cs#L20
Parameter 'multiplexerSettings' is unread.
Test: src/libp2p/Libp2p.Core.TestsBase/E2e/TestBuilder.cs#L29
Parameter 'PeerStore peerStore' is captured into the state of the enclosing type and its value is also passed to the base constructor. The value might be captured by the base class as well.
Test: src/libp2p/Libp2p.Core.TestsBase/LocalPeerStub.cs#L45
Nullability of reference types in type of parameter 'addrs' of 'Task LocalPeerStub.StartListenAsync(Multiaddress[] addrs, CancellationToken token = default(CancellationToken))' doesn't match implicitly implemented member 'Task ILocalPeer.StartListenAsync(Multiaddress[]? addrs = null, CancellationToken token = default(CancellationToken))' (possibly because of nullability attributes).
Test: src/libp2p/Libp2p.Core/Stream.cs#L11
The field 'ChannelStream.logger' is never used
Test: src/libp2p/Libp2p.Core/TransportContext.cs#L28
Parameter 'Activity? context' is captured into the state of the enclosing type and its value is also passed to the base constructor. The value might be captured by the base class as well.
Test: src/libp2p/Libp2p.Core/TransportContext.cs#L28
Parameter 'ProtocolRef proto' is captured into the state of the enclosing type and its value is also passed to the base constructor. The value might be captured by the base class as well.
Test: src/libp2p/Libp2p.Core/TransportContext.cs#L28
Parameter 'LocalPeer peer' is captured into the state of the enclosing type and its value is also passed to the base constructor. The value might be captured by the base class as well.
Test: src/libp2p/Libp2p.Core/Stream.cs#L17
Non-nullable field 'logger' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
Test: src/libp2p/Libp2p.Core/Context/NewSessionContext.cs#L19
'NewSessionContext.Activity' hides inherited member 'ContextBase.Activity'. Use the new keyword if hiding was intended.
Test: src/libp2p/Libp2p.Protocols.Pubsub/PubsubRouter.cs#L223
Dereference of a possibly null reference.
Test: src/libp2p/Libp2p.Core.Benchmarks/Benchmarks.cs#L27
Non-nullable field 'revChan' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
Test: src/libp2p/Libp2p.Core.Benchmarks/Benchmarks.cs#L26
Non-nullable field 'chan' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
Test: src/libp2p/Libp2p.Protocols.Noise/NoiseProtocol.cs#L20
Parameter 'multiplexerSettings' is unread.
Test: src/libp2p/Libp2p.Core/Stream.cs#L11
The field 'ChannelStream.logger' is never used
Test: src/libp2p/Libp2p.Core/TransportContext.cs#L28
Parameter 'Activity? context' is captured into the state of the enclosing type and its value is also passed to the base constructor. The value might be captured by the base class as well.
Test: src/libp2p/Libp2p.Core/TransportContext.cs#L28
Parameter 'ProtocolRef proto' is captured into the state of the enclosing type and its value is also passed to the base constructor. The value might be captured by the base class as well.
Test: src/libp2p/Libp2p.Core/TransportContext.cs#L28
Parameter 'LocalPeer peer' is captured into the state of the enclosing type and its value is also passed to the base constructor. The value might be captured by the base class as well.
Test: src/libp2p/Libp2p.Core/Stream.cs#L17
Non-nullable field 'logger' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
Test: src/libp2p/Libp2p.Core/Context/NewSessionContext.cs#L19
'NewSessionContext.Activity' hides inherited member 'ContextBase.Activity'. Use the new keyword if hiding was intended.