Skip to content

Commit a8e9743

Browse files
flcl42Marchhill
andauthored
Apply suggestions from code review
Co-authored-by: Marc <Marchhill@users.noreply.github.com>
1 parent d6c7dcb commit a8e9743

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

src/libp2p/Libp2p.Protocols.Identify/IdentifyProtocolBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-FileCopyrightText: 2023 Demerzel Solutions Limited
1+
// SPDX-FileCopyrightText: 2025 Demerzel Solutions Limited
22
// SPDX-License-Identifier: MIT
33

44
using Google.Protobuf;

src/libp2p/Libp2p.Protocols.Noise/NoiseProtocol.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ private static Task ExchangeData(Transport transport, IChannel downChannel, ICha
226226
ReadResult lengthBytesReadResult = await downChannel.ReadAsync(2, ReadBlockingMode.WaitAll);
227227
if (lengthBytesReadResult.Result != IOResult.Ok)
228228
{
229-
logger?.LogDebug("End receiving packet length, due to {}", lengthBytesReadResult.Result);
229+
logger?.LogDebug("Receiving packet length failed due to {}", lengthBytesReadResult.Result);
230230
return;
231231
}
232232

@@ -235,7 +235,7 @@ private static Task ExchangeData(Transport transport, IChannel downChannel, ICha
235235
ReadResult dataReadResult = await downChannel.ReadAsync(length);
236236
if (dataReadResult.Result != IOResult.Ok)
237237
{
238-
logger?.LogDebug("End receiving header, due to {}", dataReadResult);
238+
logger?.LogDebug("Receiving header failed due to {}", dataReadResult);
239239

240240
return;
241241
}
@@ -246,7 +246,7 @@ private static Task ExchangeData(Transport transport, IChannel downChannel, ICha
246246
IOResult writeResult = await upChannel.WriteAsync(new ReadOnlySequence<byte>(buffer, 0, bytesRead));
247247
if (writeResult != IOResult.Ok)
248248
{
249-
logger?.LogDebug("End receiving, due to {}", dataReadResult);
249+
logger?.LogDebug("Receiving data failed due to {}", dataReadResult);
250250
return;
251251
}
252252
}

src/libp2p/Libp2p.Protocols.Pubsub/PubsubRouter.Rpc.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ private void HandleNewMessages(PeerId peerId, IEnumerable<Message> messages, Con
7272
if (logger?.IsEnabled(LogLevel.Trace) is true)
7373
{
7474
int knownMessages = messages.Select(_settings.GetMessageId).Count(messageId => _limboMessageCache.Contains(messageId) || _messageCache!.Contains(messageId));
75-
//logger?.LogTrace($"Messages received: {messages.Count()}, already known: {knownMessages}");
75+
logger?.LogTrace($"Messages received: {messages.Count()}, already known: {knownMessages}");
7676
}
7777
else
7878
{

src/libp2p/Libp2p.Protocols.Yamux.Tests/DataWindowTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-FileCopyrightText: 2024 Demerzel Solutions Limited
1+
// SPDX-FileCopyrightText: 2025 Demerzel Solutions Limited
22
// SPDX-License-Identifier: MIT
33

44
namespace Nethermind.Libp2p.Protocols.Yamux.Tests;

src/libp2p/Libp2p.Protocols.Yamux/ChannelState.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-FileCopyrightText: 2023 Demerzel Solutions Limited
1+
// SPDX-FileCopyrightText: 2025 Demerzel Solutions Limited
22
// SPDX-License-Identifier: MIT
33

44
using Nethermind.Libp2p.Core;

0 commit comments

Comments
 (0)