Skip to content

Commit 10739f6

Browse files
committed
minor fixes after rebase
1 parent 6f44b08 commit 10739f6

File tree

6 files changed

+18
-312
lines changed

6 files changed

+18
-312
lines changed

core/contract.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,7 @@ func ContractStorage(addr, key *felt.Felt, txn db.IndexedBatch) (felt.Felt, erro
169169
if err != nil {
170170
return felt.Felt{}, err
171171
}
172-
storage, err := cStorage.Get(key)
173-
return storage, err
172+
return cStorage.Get(key)
174173
}
175174

176175
// ContractClassHash returns hash of the class that the contract at the given address instantiates.

core/trie/trie_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,7 @@ func TestPutZero(t *testing.T) {
175175
require.NoError(t, err)
176176
keys = append(keys, key)
177177

178-
var root felt.Felt
179-
root, err = tempTrie.Root()
178+
root, err := tempTrie.Hash()
180179
require.NoError(t, err)
181180
roots = append(roots, &root)
182181
}
@@ -239,8 +238,7 @@ func TestTrie(t *testing.T) {
239238
require.NoError(t, err)
240239
keys = append(keys, key)
241240

242-
var root felt.Felt
243-
root, err = tempTrie.Root()
241+
root, err := tempTrie.Hash()
244242
require.NoError(t, err)
245243
roots = append(roots, &root)
246244
}

core/trie2/triedb/rawdb/database.go

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,26 +100,29 @@ func (d *Database) Update(
100100
}
101101

102102
for path, n := range classNodes {
103-
if err := d.updateNode(batch, db.ClassTrie, &felt.Address{}, &path, n, true); err != nil {
103+
err := d.updateNode(batch, db.ClassTrie, &felt.Address{}, &path, n, true)
104+
if err != nil {
104105
return err
105106
}
106107
}
107108

108109
for path, n := range contractNodes {
109-
if err := d.updateNode(batch, db.ContractTrieContract, &felt.Address{}, &path, n, false); err != nil {
110+
err := d.updateNode(batch, db.ContractTrieContract, &felt.Address{}, &path, n, false)
111+
if err != nil {
110112
return err
111113
}
112114
}
113115

114116
for owner, nodes := range contractStorageNodes {
115117
for path, n := range nodes {
116-
if err := d.updateNode(batch, db.ContractTrieStorage, &owner, &path, n, false); err != nil {
118+
err := d.updateNode(batch, db.ContractTrieStorage, &owner, &path, n, false)
119+
if err != nil {
117120
return err
118121
}
119122
}
120123
}
121124

122-
return nil
125+
return batch.Write()
123126
}
124127

125128
func (d *Database) updateNode(
@@ -131,19 +134,21 @@ func (d *Database) updateNode(
131134
isClass bool,
132135
) error {
133136
if _, deleted := n.(*trienode.DeletedNode); deleted {
134-
if err := trieutils.DeleteNodeByPath(batch, bucket, owner, path, n.IsLeaf()); err != nil {
137+
err := trieutils.DeleteNodeByPath(batch, bucket, owner, path, n.IsLeaf())
138+
if err != nil {
135139
return err
136140
}
137141
d.cleanCache.deleteNode(owner, path, isClass)
138142
} else {
139-
if err := trieutils.WriteNodeByPath(
143+
err := trieutils.WriteNodeByPath(
140144
batch,
141145
bucket,
142146
owner,
143147
path,
144148
n.IsLeaf(),
145149
n.Blob(),
146-
); err != nil {
150+
)
151+
if err != nil {
147152
return err
148153
}
149154
d.cleanCache.putNode(owner, path, isClass, n.Blob())

mocks/mock_common_state.go

Lines changed: 0 additions & 295 deletions
This file was deleted.

mocks/mock_gateway.go

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)