fixes after update

Author: MaksymMalicki

core/common_state.go

@@ -17,7 +17,6 @@ type CommonState interface {
 		update *StateUpdate,
 		declaredClasses map[felt.Felt]ClassDefinition,
 		skipVerifyNewRoot bool,
-		flushChanges bool,
 	) error
 	Revert(blockNum uint64, update *StateUpdate) error
 	Commitment() (felt.Felt, error)

core/state/state_test.go

@@ -265,7 +265,7 @@ func TestClass(t *testing.T) {
 	require.NoError(t, state.Update(0, su0, map[felt.Felt]core.ClassDefinition{
 		*deprecatedCairoHash: deprecatedCairoClass,
 		*sierraHash:          sierraClass,
-	}, false, true))
+	}, false))
 	require.NoError(t, batch.Write())
 	gotSierraClass, err := state.Class(sierraHash)
 	require.NoError(t, err)

core/state/statefactory/state_factory.go

@@ -34,13 +34,14 @@ func NewStateFactory(
 func (sf *StateFactory) NewState(
 	stateRoot *felt.Felt,
 	txn db.IndexedBatch,
+	batch db.Batch,
 ) (core.CommonState, error) {
 	if !sf.UseNewState {
 		deprecatedState := core.NewState(txn)
 		return deprecatedState, nil
 	}
 
-	state, err := state.New(stateRoot, sf.stateDB)
+	state, err := state.New(stateRoot, sf.stateDB, batch)
 	if err != nil {
 		return nil, err
 	}
@@ -72,7 +73,7 @@ func (sf *StateFactory) EmptyState() (core.CommonStateReader, error) {
 		emptyState := core.NewState(txn)
 		return emptyState, nil
 	}
-	state, err := state.New(&felt.Zero, sf.stateDB)
+	state, err := state.New(&felt.Zero, sf.stateDB, nil)
 	if err != nil {
 		return nil, err
 	}

db/pebble/db.go

@@ -28,24 +28,19 @@ type DB struct {
 
 // New opens a new database at the given path with default options
 func New(path string, options ...Option) (db.KeyValueStore, error) {
-	opts := pebble.Options{}
-	for _, option := range options {
-		if err := option(&opts); err != nil {
-			return nil, err
-		}
-	}
-
-	opts := &pebble.Options{
-		Logger:                    dbLog,
-		Cache:                     pebble.NewCache(int64(cacheSizeMB * utils.Megabyte)),
-		MaxOpenFiles:              maxOpenFiles,
+	opts := pebble.Options{
 		L0CompactionFileThreshold: 8,
 		L0StopWritesThreshold:     24,
 		MemTableSize:              8 * utils.Megabyte,
 		MaxConcurrentCompactions:  func() int { return 2 },
 	}
+	for _, option := range options {
+		if err := option(&opts); err != nil {
+			return nil, err
+		}
+	}
 
-	return newPebble(path, opts)
+	return newPebble(path, &opts)
 }
 
 func newPebble(path string, options *pebble.Options) (*DB, error) {

vm/vm_test.go

@@ -198,7 +198,8 @@ func TestCallCairo(t *testing.T) {
 	batch := testDB.NewBatch()
 	testState, err := stateFactory.NewState(&felt.Zero, txn, batch)
 	require.NoError(t, err)
-	state, err := stateFactory.NewState(&felt.Zero, txn)
+	batch := testDB.NewBatch()
+	state, err := stateFactory.NewState(&felt.Zero, txn, batch)
 	newRoot := felt.NewUnsafeFromString[felt.Felt](
 		"0x2650cef46c190ec6bb7dc21a5a36781132e7c883b27175e625031149d4f1a84",
 	)
@@ -212,7 +213,7 @@ func TestCallCairo(t *testing.T) {
 		},
 	}
 	declaredClass := map[felt.Felt]core.ClassDefinition{*classHash: simpleClass}
-	require.NoError(t, state.Update(0, &firstStateUpdate, declaredClass, false, true))
+	require.NoError(t, state.Update(0, &firstStateUpdate, declaredClass, false))
 	require.NoError(t, batch.Write())
 
 	logLevel := utils.NewLogLevel(utils.ERROR)
@@ -280,6 +281,10 @@ func TestCallCairo(t *testing.T) {
 		require.NoError(t, batch.Write())
 	}
 
+	if statetestutils.UseNewState() {
+		require.NoError(t, batch.Write())
+	}
+
 	ret, err = vm.Call(
 		&callInfo,
 		&BlockInfo{Header: &core.Header{Number: 1}},