Fix gas limit calculation in eth simulate (#9663)

* Fix gas limit calculation

* Small fix

* Try fix

* revert flag

* Subtract

* known tests

* fix failing tests file

Author: deffrian

scripts/known-failing-hive-tests.txt

@@ -5,8 +5,6 @@ eth_getStorageAt/get-storage-invalid-key-too-large (nethermind)
 eth_createAccessList/create-al-abi-revert (nethermind)
 eth_sendRawTransaction/send-blob-tx (nethermind)
 eth_simulateV1/ethSimulate-instrict-gas-38013 (nethermind)
-eth_simulateV1/ethSimulate-run-gas-spending (nethermind)
-eth_simulateV1/ethSimulate-run-out-of-gas-in-block-38015 (nethermind)
 eth_simulateV1/ethSimulate-two-blocks-with-complete-eth-sends (nethermind)
 eth_simulateV1/ethSimulate-use-as-many-features-as-possible (nethermind)
 

src/Nethermind/Nethermind.Facade/Simulate/SimulateBridgeHelper.cs

@@ -106,7 +106,7 @@ private void Simulate<TTrace>(BlockHeader parent,
         IWorldState stateProvider = env.WorldState;
         parent = GetParent(parent, payload, blockTree);
 
-        env.SimulateRequestState.TotalGasLeft = long.Min(parent.GasLimit, gasCapLimit);
+        env.SimulateRequestState.TotalGasLeft = gasCapLimit;
 
         if (payload.BlockStateCalls is not null)
         {
@@ -118,6 +118,7 @@ private void Simulate<TTrace>(BlockHeader parent,
                 nonceCache.Clear();
 
                 (BlockHeader callHeader, IReleaseSpec spec) = GetCallHeader(env.SpecProvider, blockCall, parent, payload.Validation);
+                env.SimulateRequestState.BlockGasLeft = callHeader.GasLimit;
                 callHeader.Hash = callHeader.CalculateHash();
 
                 TransactionWithSourceDetails[] calls = blockCall.Calls ?? [];

src/Nethermind/Nethermind.Facade/Simulate/SimulateRequestState.cs

@@ -10,5 +10,6 @@ public class SimulateRequestState
     public bool Validate { get; set; }
     public UInt256? BlobBaseFeeOverride { get; set; }
     public long TotalGasLeft { get; set; }
+    public long BlockGasLeft { get; set; }
     public bool[] TxsWithExplicitGas { get; set; }
 }

src/Nethermind/Nethermind.Facade/Simulate/SimulateTransactionProcessorAdapter.cs

@@ -18,14 +18,15 @@ public TransactionResult Execute(Transaction transaction, ITxTracer txTracer)
         // The gas limit per tx go down as the block is processed.
         if (!simulateRequestState.TxsWithExplicitGas[_currentTxIndex])
         {
-            transaction.GasLimit = simulateRequestState.TotalGasLeft;
+            transaction.GasLimit = long.Min(simulateRequestState.BlockGasLeft, simulateRequestState.TotalGasLeft);
         }
         transaction.Hash = transaction.CalculateHash();
 
         TransactionResult result = simulateRequestState.Validate ? transactionProcessor.Execute(transaction, txTracer) : transactionProcessor.Trace(transaction, txTracer);
 
         // Keep track of gas left
         simulateRequestState.TotalGasLeft -= transaction.SpentGas;
+        simulateRequestState.BlockGasLeft -= transaction.SpentGas;
         _currentTxIndex++;
         return result;
     }