Fix self destruct missing clear

Author: asdacap

src/Nethermind/Nethermind.Db.Rocks/Config/DbConfig.cs

@@ -508,5 +508,5 @@ public class DbConfig : IDbConfig
         TrieNodeConfig +
         "";
     public string? FlatStorageTopNodesNodesDbAdditionalRocksDbOptions { get; set; }
-    public ulong PreimageDbWriteBufferSize { get; set; } = (ulong)256.MiB();
+    public ulong PreimageDbWriteBufferSize { get; set; } = (ulong)16.MiB();
 }

src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs

@@ -629,6 +629,7 @@ private TransactionResult BuildExecutionEnvironment(
 
         protected virtual bool ShouldValidate(ExecutionOptions opts) => !opts.HasFlag(ExecutionOptions.SkipValidation);
 
+        [MethodImpl(MethodImplOptions.NoOptimization)]
         private int ExecuteEvmCall<TTracingInst>(
             Transaction tx,
             BlockHeader header,

src/Nethermind/Nethermind.State/Flat/FlatDiffRepository.cs

@@ -691,7 +691,7 @@ public void Add(Snapshot snapshot)
                     }
                     if (deleted > 0)
                     {
-                        _logger.Warn($"Should selfdestruct {toSelfDestructStorage.Key}. Deleted {deleted}");
+                        _logger.Warn($"Should selfdestruct {toSelfDestructStorage.Key}. Deleted {deleted}. Snapshot range {snapshot.From} {snapshot.To}");
                         throw new Exception($"Should sefl destruct not called properly {toSelfDestructStorage.Key}");
                     }
                     continue;

src/Nethermind/Nethermind.State/Flat/SnapshotBundle.cs

@@ -464,7 +464,7 @@ public void SetAccount(AddressAsKey addr, Account? account)
     {
         if (addr == FlatWorldStateScope.DebugAddress)
         {
-            Console.Error.WriteLine("set to {a}");
+            Console.Error.WriteLine($"set to {account}");
         }
         _changedAccounts[addr] = account;
     }
@@ -549,13 +549,17 @@ public Snapshot CompactToKnownState()
             {
                 var address = addrK.Key;
                 var isNewAccount = addrK.Value;
-                selfDestructedStorageAddresses[address] = isNewAccount;
-
                 if (!isNewAccount)
                 {
+                    selfDestructedStorageAddresses[address] = false;
                     addressToClear.Add(address);
                     addressHashToClear.Add(address.Value.ToAccountPath.ToCommitment());
                 }
+                else
+                {
+                    // Note, if its already false, we should not set it to true
+                    selfDestructedStorageAddresses.TryAdd(address, true);
+                }
             }
 
             if (addressToClear.Count > 0)
@@ -638,7 +642,7 @@ public void Clear(Address address, Hash256AsKey addressHash)
             isNewAccount = account == null;
             if (address == FlatWorldStateScope.DebugAddress)
             {
-                Console.Error.WriteLine("The clear is is new");
+                Console.Error.WriteLine($"The clear newness is {isNewAccount}");
             }
         }
         else

src/Nethermind/Nethermind.State/PersistentStorageProvider.cs

@@ -18,6 +18,7 @@
 using Nethermind.Evm.Tracing.State;
 using Nethermind.Int256;
 using Nethermind.Logging;
+using Nethermind.State.Flat.ScopeProvider;
 using Nethermind.Trie;
 
 namespace Nethermind.State;
@@ -214,7 +215,9 @@ protected override void CommitCore(IStorageTracer tracer)
         foreach (AddressAsKey address in toUpdateRoots)
         {
             // since the accounts could be empty accounts that are removing (EIP-158)
-            if (_stateProvider.AccountExists(address))
+            // Note: it could be that the TX remove the account but the underlying account was originally not missing
+            // hence, the storage Clear need to be called, hence the additional call to _currentScope.Get
+            if (_stateProvider.AccountExists(address) || _currentScope.Get(address) is not null)
             {
                 _toUpdateRoots[address] = true;
                 // Add storage tree, will accessed later, which may be in parallel
@@ -268,6 +271,7 @@ void UpdateRootHashesSingleThread()
             {
                 if (!_toUpdateRoots.TryGetValue(kvp.Key, out bool hasChanges) || !hasChanges)
                 {
+                    if (kvp.Key == FlatWorldStateScope.DebugAddress) Console.Error.WriteLine("Update skipped");
                     // Wasn't updated don't recalculate
                     continue;
                 }
@@ -402,6 +406,11 @@ public override void ClearStorage(Address address)
     {
         base.ClearStorage(address);
 
+        if (address == FlatWorldStateScope.DebugAddress)
+        {
+            Console.Error.WriteLine($"Clear on world state for debug address {address}");
+        }
+
         _toUpdateRoots.TryAdd(address, true);
 
         PerContractState state = GetOrCreateStorage(address);
@@ -561,6 +570,11 @@ private byte[] LoadFromTreeStorage(StorageCell storageCell)
             int writes = 0;
             int skipped = 0;
 
+            if (_address == FlatWorldStateScope.DebugAddress && BlockChange.HasClear)
+            {
+                Console.Error.WriteLine("Clear in process storage change");
+            }
+
             if (BlockChange.HasClear)
             {
                 storageWriteBatch.Clear();

src/Nethermind/Nethermind.State/StateProvider.cs

@@ -22,6 +22,7 @@
 using Nethermind.Evm.Tracing.State;
 using Nethermind.Int256;
 using Nethermind.Logging;
+using Nethermind.State.Flat.ScopeProvider;
 using Metrics = Nethermind.Db.Metrics;
 using static Nethermind.State.StateProvider;
 
@@ -177,14 +178,11 @@ static Account ThrowIfNull(Address address)
                 => throw new InvalidOperationException($"Account {address} is null when updating code hash");
         }
 
-        // 0x9290084cde3cfc1085e5e8aa6ff1fb141b3cebc4ac64f4ce937a2c9b5cd85a69, // Hash
-        private Address importantAddress = new Address("0xf664829682daf488be5318dae198a69ce27fb31b");
-
         private void SetNewBalance(Address address, in UInt256 balanceChange, IReleaseSpec releaseSpec, bool isSubtracting)
         {
             _needsStateRootUpdate = true;
 
-            if (address == importantAddress)
+            if (address == FlatWorldStateScope.DebugAddress)
             {
                 Console.Error.WriteLine($"Balance change {balanceChange}, {isSubtracting}");
             }
@@ -335,9 +333,9 @@ public byte[] GetCode(Address address)
 
         public void DeleteAccount(Address address)
         {
-            if (address == importantAddress)
+            if (address == FlatWorldStateScope.DebugAddress)
             {
-                Console.Error.WriteLine($"delete address");
+                Console.Error.WriteLine($"delete address {Environment.StackTrace}");
             }
             _needsStateRootUpdate = true;
             PushDelete(address);
@@ -787,7 +785,13 @@ private void PushTouch(Address address, Account account, IReleaseSpec releaseSpe
         }
 
         private void PushDelete(Address address)
-            => Push(address, null, ChangeType.Delete);
+        {
+            Push(address, null, ChangeType.Delete);
+            if (address == FlatWorldStateScope.DebugAddress)
+            {
+                Console.Error.WriteLine("Delete account");
+            }
+        }
 
         private void Push(Address address, Account? touchedAccount, ChangeType changeType)
         {
@@ -798,7 +802,7 @@ private void Push(Address address, Account? touchedAccount, ChangeType changeTyp
                 return;
             }
 
-            if (address == importantAddress)
+            if (address == FlatWorldStateScope.DebugAddress)
             {
                 Console.Error.WriteLine($"Push {changeType}, {touchedAccount}");
             }
@@ -811,7 +815,7 @@ private void PushNew(Address address, Account account)
             Stack<int> stack = SetupCache(address);
             stack.Push(_changes.Count);
             _changes.Add(new Change(address, account, ChangeType.New));
-            if (address == importantAddress)
+            if (address == FlatWorldStateScope.DebugAddress)
             {
                 Console.Error.WriteLine($"Push new {account}");
             }
@@ -822,7 +826,7 @@ private void PushRecreateEmpty(Address address, Account account, Stack<int> stac
         {
             stack.Push(_changes.Count);
             _changes.Add(new Change(address, account, ChangeType.RecreateEmpty));
-            if (address == importantAddress)
+            if (address == FlatWorldStateScope.DebugAddress)
             {
                 Console.Error.WriteLine($"Push recreate empty {account}");
             }