Fix debug module wrong configuration (#8185)

Author: asdacap

src/Nethermind/Nethermind.Consensus/Tracing/GethStyleTracer.cs

@@ -122,20 +122,17 @@ public GethLikeTxTrace Trace(Hash256 blockHash, int txIndex, GethTraceOptions op
         if (tx.Hash is null) throw new InvalidOperationException("Cannot trace transactions without tx hash set.");
 
         block = block.WithReplacedBodyCloned(BlockBody.WithOneTransactionOnly(tx));
-        lock (_env) //env shouldn't be shared, but can't find the root cause where it could be
+        using IOverridableTxProcessingScope scope = _env.BuildAndOverride(block.Header, options.StateOverrides);
+        IBlockTracer<GethLikeTxTrace> blockTracer = CreateOptionsTracer(block.Header, options with { TxHash = tx.Hash });
+        try
         {
-            using IOverridableTxProcessingScope scope = _env.BuildAndOverride(block.Header, options.StateOverrides);
-            IBlockTracer<GethLikeTxTrace> blockTracer = CreateOptionsTracer(block.Header, options with { TxHash = tx.Hash });
-            try
-            {
-                _processor.Process(block, ProcessingOptions.Trace, blockTracer.WithCancellation(cancellationToken));
-                return blockTracer.BuildResult().SingleOrDefault();
-            }
-            catch
-            {
-                blockTracer.TryDispose();
-                throw;
-            }
+            _processor.Process(block, ProcessingOptions.Trace, blockTracer.WithCancellation(cancellationToken));
+            return blockTracer.BuildResult().SingleOrDefault();
+        }
+        catch
+        {
+            blockTracer.TryDispose();
+            throw;
         }
     }
 
@@ -195,21 +192,18 @@ public IEnumerable<string> TraceBadBlockToFile(Hash256 blockHash, GethTraceOptio
     {
         ArgumentNullException.ThrowIfNull(txHash);
 
-        lock (_env) //env shouldn't be shared, but can't find the root cause where it could be
-        {
-            using IOverridableTxProcessingScope scope = _env.BuildAndOverride(block.Header, options.StateOverrides);
-            IBlockTracer<GethLikeTxTrace> tracer = CreateOptionsTracer(block.Header, options with { TxHash = txHash });
+        using IOverridableTxProcessingScope scope = _env.BuildAndOverride(block.Header, options.StateOverrides);
+        IBlockTracer<GethLikeTxTrace> tracer = CreateOptionsTracer(block.Header, options with { TxHash = txHash });
 
-            try
-            {
-                _processor.Process(block, processingOptions, tracer.WithCancellation(cancellationToken));
-                return tracer.BuildResult().SingleOrDefault();
-            }
-            catch
-            {
-                tracer.TryDispose();
-                throw;
-            }
+        try
+        {
+            _processor.Process(block, processingOptions, tracer.WithCancellation(cancellationToken));
+            return tracer.BuildResult().SingleOrDefault();
+        }
+        catch
+        {
+            tracer.TryDispose();
+            throw;
         }
     }
 
@@ -236,20 +230,17 @@ private IReadOnlyCollection<GethLikeTxTrace> TraceBlock(Block? block, GethTraceO
             if (!_blockTree.IsMainChain(parent.Hash)) throw new InvalidOperationException("Cannot trace orphaned blocks");
         }
 
-        lock (_env) //env shouldn't be shared, but can't find the root cause where it could be
+        using IOverridableTxProcessingScope scope = _env.BuildAndOverride(block.Header, options.StateOverrides);
+        IBlockTracer<GethLikeTxTrace> tracer = CreateOptionsTracer(block.Header, options);
+        try
         {
-            using IOverridableTxProcessingScope scope = _env.BuildAndOverride(block.Header, options.StateOverrides);
-            IBlockTracer<GethLikeTxTrace> tracer = CreateOptionsTracer(block.Header, options);
-            try
-            {
-                _processor.Process(block, ProcessingOptions.Trace, tracer.WithCancellation(cancellationToken));
-                return tracer.BuildResult();
-            }
-            catch
-            {
-                tracer.TryDispose();
-                throw;
-            }
+            _processor.Process(block, ProcessingOptions.Trace, tracer.WithCancellation(cancellationToken));
+            return tracer.BuildResult();
+        }
+        catch
+        {
+            tracer.TryDispose();
+            throw;
         }
     }
 

src/Nethermind/Nethermind.JsonRpc/Modules/DebugModule/IDebugRpcModule.cs

@@ -27,31 +27,31 @@ public interface IDebugRpcModule : IRpcModule
         IsSharable = true)]
     ResultWrapper<bool> debug_resetHead(Hash256 blockHash);
 
-    [JsonRpcMethod(Description = "This method will attempt to run the transaction in the exact same manner as it was executed on the network. It will replay any transaction that may have been executed prior to this one before it will finally attempt to execute the transaction that corresponds to the given hash.", IsImplemented = true, IsSharable = true)]
+    [JsonRpcMethod(Description = "This method will attempt to run the transaction in the exact same manner as it was executed on the network. It will replay any transaction that may have been executed prior to this one before it will finally attempt to execute the transaction that corresponds to the given hash.", IsImplemented = true, IsSharable = false)]
     ResultWrapper<GethLikeTxTrace> debug_traceTransaction(Hash256 transactionHash, GethTraceOptions options = null);
 
-    [JsonRpcMethod(Description = "This method lets you run an eth_call within the context of the given block execution using the final state of parent block as the base. The block can be specified either by hash or by number. It takes the same input object as a eth_call. It returns the same output as debug_traceTransaction.", IsImplemented = true, IsSharable = true)]
+    [JsonRpcMethod(Description = "This method lets you run an eth_call within the context of the given block execution using the final state of parent block as the base. The block can be specified either by hash or by number. It takes the same input object as a eth_call. It returns the same output as debug_traceTransaction.", IsImplemented = true, IsSharable = false)]
     ResultWrapper<GethLikeTxTrace> debug_traceCall(TransactionForRpc call, BlockParameter? blockParameter = null, GethTraceOptions? options = null);
 
-    [JsonRpcMethod(Description = "", IsSharable = true)]
+    [JsonRpcMethod(Description = "", IsSharable = false)]
     ResultWrapper<GethLikeTxTrace> debug_traceTransactionByBlockAndIndex(BlockParameter blockParameter, int txIndex, GethTraceOptions options = null);
 
-    [JsonRpcMethod(Description = "", IsSharable = true)]
+    [JsonRpcMethod(Description = "", IsSharable = false)]
     ResultWrapper<GethLikeTxTrace> debug_traceTransactionByBlockhashAndIndex(Hash256 blockHash, int txIndex, GethTraceOptions options = null);
 
-    [JsonRpcMethod(Description = "Returns the full stack trace of all invoked opcodes of all transactions that were included in the block specified. The parent of the block must be present or it will fail.", IsImplemented = true, IsSharable = true)]
+    [JsonRpcMethod(Description = "Returns the full stack trace of all invoked opcodes of all transactions that were included in the block specified. The parent of the block must be present or it will fail.", IsImplemented = true, IsSharable = false)]
     ResultWrapper<IReadOnlyCollection<GethLikeTxTrace>> debug_traceBlock(byte[] blockRlp, GethTraceOptions options = null);
 
-    [JsonRpcMethod(Description = "Similar to debug_traceBlock, this method accepts a block number as well as \"latest\" or \"finalized\" and replays the block that is already present in the database.", IsImplemented = true, IsSharable = true)]
+    [JsonRpcMethod(Description = "Similar to debug_traceBlock, this method accepts a block number as well as \"latest\" or \"finalized\" and replays the block that is already present in the database.", IsImplemented = true, IsSharable = false)]
     ResultWrapper<IReadOnlyCollection<GethLikeTxTrace>> debug_traceBlockByNumber(BlockParameter blockParameter, GethTraceOptions options = null);
 
-    [JsonRpcMethod(Description = "Similar to debug_traceBlock, this method accepts a block hash and replays the block that is already present in the database.", IsImplemented = true, IsSharable = true)]
+    [JsonRpcMethod(Description = "Similar to debug_traceBlock, this method accepts a block hash and replays the block that is already present in the database.", IsImplemented = true, IsSharable = false)]
     ResultWrapper<IReadOnlyCollection<GethLikeTxTrace>> debug_traceBlockByHash(Hash256 blockHash, GethTraceOptions options = null);
 
     [JsonRpcMethod(Description = "", IsImplemented = false, IsSharable = false)]
     ResultWrapper<GethLikeTxTrace[]> debug_traceBlockFromFile(string fileName, GethTraceOptions options = null);
 
-    [JsonRpcMethod(Description = "", IsImplemented = false, IsSharable = false)]
+    [JsonRpcMethod(Description = "", IsImplemented = false, IsSharable = true)]
     ResultWrapper<object> debug_dumpBlock(BlockParameter blockParameter);
 
     [JsonRpcMethod(Description = "", IsImplemented = false, IsSharable = true)]
@@ -60,7 +60,7 @@ public interface IDebugRpcModule : IRpcModule
     [JsonRpcMethod(Description = "Retrieves a block in the RLP-serialized form.", IsImplemented = true, IsSharable = true)]
     ResultWrapper<byte[]> debug_getBlockRlp(long number);
 
-    [JsonRpcMethod(Description = "Retrieves a block in the RLP-serialized form.", IsImplemented = true, IsSharable = false)]
+    [JsonRpcMethod(Description = "Retrieves a block in the RLP-serialized form.", IsImplemented = true, IsSharable = true)]
     ResultWrapper<byte[]> debug_getBlockRlpByHash(Hash256 hash);
 
     [JsonRpcMethod(Description = "", IsImplemented = false, IsSharable = true)]