Cache

Author: flcl42

src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthRpcModule.cs

@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: LGPL-3.0-only
 
 using System;
+using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Linq;
 using System.Security;
@@ -67,6 +68,8 @@ public partial class EthRpcModule(
     IForkInfo forkInfo,
     ulong? secondsPerSlot) : IEthRpcModule
 {
+    private static readonly ConcurrentDictionary<ForkId, ForkConfig> forkConfigCache = [];
+
     protected readonly Encoding _messageEncoding = Encoding.UTF8;
     protected readonly IJsonRpcConfig _rpcConfig = rpcConfig ?? throw new ArgumentNullException(nameof(rpcConfig));
     protected readonly IBlockchainBridge _blockchainBridge = blockchainBridge ?? throw new ArgumentNullException(nameof(blockchainBridge));
@@ -805,19 +808,17 @@ private ResultWrapper<TResult> GetStateFailureResult<TResult>(BlockHeader header
     public ResultWrapper<JsonNode> eth_config(bool showAllForks = false)
     {
         ForkActivationsSummary forks = forkInfo.GetForkActivationsSummary(_blockFinder.Head?.Header);
-        IReadOnlyList<ForkConfig>? allForkConfigs = null;
+        List<ForkConfig>? allForkConfigs = null;
 
         if (showAllForks)
         {
-            Fork[] forkSchedule = forkInfo.GetAllForks();
-            List<ForkConfig> forkConfigs = new(forkSchedule.Length);
+            ReadOnlySpan<Fork> forkSchedule = forkInfo.GetAllForks();
+            allForkConfigs = new(forkSchedule.Length);
 
             foreach (Fork scheduledFork in forkSchedule)
             {
-                forkConfigs.Add(BuildForkConfig(scheduledFork, _specProvider));
+                allForkConfigs.Add(BuildForkConfig(scheduledFork, _specProvider));
             }
-
-            allForkConfigs = forkConfigs;
         }
 
         return ResultWrapper<JsonNode>.Success(JsonNode.Parse(JsonSerializer.Serialize(new ForkConfigSummary
@@ -833,9 +834,14 @@ public ResultWrapper<JsonNode> eth_config(bool showAllForks = false)
 
         static ForkConfig BuildForkConfig(Fork fork, ISpecProvider specProvider)
         {
+            if (forkConfigCache.TryGetValue(fork.Id, out ForkConfig config))
+            {
+                return config;
+            }
+
             IReleaseSpec spec = specProvider.GetSpec(fork.Activation.BlockNumber, fork.Activation.Timestamp);
 
-            return new ForkConfig
+            return forkConfigCache[fork.Id] = new ForkConfig
             {
                 ActivationTime = fork.Activation.Timestamp is not null ? (int)fork.Activation.Timestamp : null,
                 ActivationBlock = fork.Activation.Timestamp is null ? (int)fork.Activation.BlockNumber : null,

src/Nethermind/Nethermind.Network/ForkInfo.cs

@@ -177,7 +177,7 @@ public ForkActivationsSummary GetForkActivationsSummary(BlockHeader? head)
             };
         }
 
-        public Fork[] GetAllForks()
+        public ReadOnlySpan<Fork> GetAllForks()
         {
             EnsureInitialized();
             return Forks;

src/Nethermind/Nethermind.Network/IForkInfo.cs

@@ -3,6 +3,7 @@
 
 using Nethermind.Core;
 using Nethermind.Core.Specs;
+using System;
 
 namespace Nethermind.Network;
 
@@ -20,7 +21,7 @@ public interface IForkInfo
 
     ForkActivationsSummary GetForkActivationsSummary(BlockHeader? head);
 
-    Fork[] GetAllForks();
+    ReadOnlySpan<Fork> GetAllForks();
 }
 
 public readonly record struct Fork(ForkActivation Activation, ForkId Id);