fix: fix resource leak in ChannelDecoder compression streams (#10865)

kseniaeremekno · web-flow · commit be56248f9f12 · 2026-03-19T15:06:08.000+01:00
Update ChannelDecoder.cs
diff --git a/src/Nethermind/Nethermind.Optimism/CL/Decoding/ChannelDecoder.cs b/src/Nethermind/Nethermind.Optimism/CL/Decoding/ChannelDecoder.cs
@@ -18,13 +18,13 @@ public static ReadOnlyMemory<byte> DecodeChannel(byte[] data)
         if ((data[0] & 0x0F) == 8 || (data[0] & 0x0F) == 15)
         {
             // zlib
-            var deflateStream = new DeflateStream(new MemoryStream(data[2..]), CompressionMode.Decompress);
+            using DeflateStream deflateStream = new(new MemoryStream(data[2..]), CompressionMode.Decompress);
             CopyDataWithLimit(deflateStream, memoryStream);
         }
         else if (data[0] == 1)
         {
             // brotli
-            BrotliStream stream = new BrotliStream(new MemoryStream(data[1..]), CompressionMode.Decompress);
+            using BrotliStream stream = new(new MemoryStream(data[1..]), CompressionMode.Decompress);
             CopyDataWithLimit(stream, memoryStream);
         }
         else

Original file line number	Diff line number	Diff line change
`@@ -18,13 +18,13 @@ public static ReadOnlyMemory<byte> DecodeChannel(byte[] data)`
`18`	`18`	`if ((data[0] & 0x0F) == 8 \|\| (data[0] & 0x0F) == 15)`
`19`	`19`	`{`
`20`	`20`	`// zlib`
`21`		`- var deflateStream = new DeflateStream(new MemoryStream(data[2..]), CompressionMode.Decompress);`
	`21`	`+ using DeflateStream deflateStream = new(new MemoryStream(data[2..]), CompressionMode.Decompress);`
`22`	`22`	`CopyDataWithLimit(deflateStream, memoryStream);`
`23`	`23`	`}`
`24`	`24`	`else if (data[0] == 1)`
`25`	`25`	`{`
`26`	`26`	`// brotli`
`27`		`- BrotliStream stream = new BrotliStream(new MemoryStream(data[1..]), CompressionMode.Decompress);`
	`27`	`+ using BrotliStream stream = new(new MemoryStream(data[1..]), CompressionMode.Decompress);`
`28`	`28`	`CopyDataWithLimit(stream, memoryStream);`
`29`	`29`	`}`
`30`	`30`	`else`