Flag is false by def; return array

Author: flcl42

src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthRpcModule.cs

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2023 Demerzel Solutions Limited
+// SPDX-FileCopyrightText: 2025 Demerzel Solutions Limited
 // SPDX-License-Identifier: LGPL-3.0-only
 
 using System;
@@ -802,15 +802,15 @@ private ResultWrapper<TResult> GetStateFailureResult<TResult>(BlockHeader header
         };
     }
 
-    public ResultWrapper<JsonNode> eth_config(bool? showAllForks = null)
+    public ResultWrapper<JsonNode> eth_config(bool showAllForks = false)
     {
         ForkActivationsSummary forks = forkInfo.GetForkActivationsSummary(_blockFinder.Head?.Header);
         IReadOnlyList<ForkConfig>? allForkConfigs = null;
 
-        if (showAllForks is true)
+        if (showAllForks)
         {
-            IReadOnlyList<Fork> forkSchedule = forkInfo.GetAllForks();
-            List<ForkConfig> forkConfigs = new(forkSchedule.Count);
+            Fork[] forkSchedule = forkInfo.GetAllForks();
+            List<ForkConfig> forkConfigs = new(forkSchedule.Length);
 
             foreach (Fork scheduledFork in forkSchedule)
             {

src/Nethermind/Nethermind.JsonRpc/Modules/Eth/IEthRpcModule.cs

@@ -1,7 +1,6 @@
-// SPDX-FileCopyrightText: 2023 Demerzel Solutions Limited
+// SPDX-FileCopyrightText: 2025 Demerzel Solutions Limited
 // SPDX-License-Identifier: LGPL-3.0-only
 
-using System;
 using System.Collections.Generic;
 using System.Text.Json.Nodes;
 using System.Threading.Tasks;
@@ -290,6 +289,6 @@ ResultWrapper<TransactionForRpc> eth_getTransactionByBlockNumberAndIndex(
         ResultWrapper<AccountInfoForRpc?> eth_getAccountInfo([JsonRpcParameter(ExampleValue = "[\"0xaa00000000000000000000000000000000000000\", \"latest\"]")] Address accountAddress, BlockParameter? blockParameter = null);
 
         [JsonRpcMethod(IsImplemented = true, Description = "Provides configuration data for the current and next fork or the full fork schedule", IsSharable = true)]
-        ResultWrapper<JsonNode> eth_config([JsonRpcParameter(Description = "Returns every known fork when true", ExampleValue = "[true]")] bool? showAllForks = null);
+        ResultWrapper<JsonNode> eth_config([JsonRpcParameter(Description = "Returns every known fork when true", ExampleValue = "[true]")] bool showAllForks = false);
     }
 }

src/Nethermind/Nethermind.Network/ForkInfo.cs

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2022 Demerzel Solutions Limited
+// SPDX-FileCopyrightText: 2025 Demerzel Solutions Limited
 // SPDX-License-Identifier: LGPL-3.0-only
 
 using Force.Crc32;
@@ -177,7 +177,7 @@ public ForkActivationsSummary GetForkActivationsSummary(BlockHeader? head)
             };
         }
 
-        public IReadOnlyList<Fork> GetAllForks()
+        public Fork[] GetAllForks()
         {
             EnsureInitialized();
             return Forks;

src/Nethermind/Nethermind.Network/IForkInfo.cs

@@ -1,7 +1,6 @@
 // SPDX-FileCopyrightText: 2025 Demerzel Solutions Limited
 // SPDX-License-Identifier: LGPL-3.0-only
 
-using System.Collections.Generic;
 using Nethermind.Core;
 using Nethermind.Core.Specs;
 
@@ -21,7 +20,7 @@ public interface IForkInfo
 
     ForkActivationsSummary GetForkActivationsSummary(BlockHeader? head);
 
-    IReadOnlyList<Fork> GetAllForks();
+    Fork[] GetAllForks();
 }
 
 public readonly record struct Fork(ForkActivation Activation, ForkId Id);